Repository navigation
fix(semconv): restore cache token compatibility aliases on SpanAttributes - #4667
Open
Quantum-Enigma-dot wants to merge 1 commit into
Open
Quantum-Enigma-dot wants to merge 1 commit into
Quantum-Enigma-dot wants to merge 1 commit into
Conversation
Author
|
This PR restores backward-compatibility aliases for cache token semantic conventions, adds regression coverage, and resolves the issue introduced during the #4243 migration. Happy to make any follow-up changes if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore cache token compatibility aliases on
SpanAttributes.Problem
PR #4243 migrated cache token semantic conventions to
GenAIAttributes, but several downstream runtime code paths and tests still reference:SpanAttributes.GEN_AI_USAGE_CACHE_READ_INPUT_TOKENSSpanAttributes.GEN_AI_USAGE_CACHE_CREATION_INPUT_TOKENSThis results in
AttributeErrorwhen cache-token code paths are exercised.Fix
SpanAttributesValidation
Fixes #4665
Summary by CodeRabbit