chore(lint): eliminate all 19 biome findings — zero lint debt in src#151
Merged
Conversation
Brings `biome check src` to ZERO findings (was 19: 9 noAssignInExpressions,
6 noImplicitAnyLet, 1 noTemplateCurlyInString, 1 unused noExplicitAny
suppression, 2 complexity). Each fixed properly, not suppressed:
- regex `let m; while ((m = re.exec(x)) !== null)` → typed-hoisted form
(`let m: RegExpExecArray | null = re.exec(x); while (m !== null) { …; m = re.exec(x) }`)
in client, executor (×3), keyword-coverage-judge, store-otlp — typed loop
vars + no assignment-in-condition.
- `??=` accumulators hoisted to a statement (tool-use-metrics, run-profile-matrix).
- anti-slop indexOf scan → hoisted, folding the advance into the next search.
- typed `let entries: Dirent[]` / `let st: ReturnType<typeof statSync>`
(skill-usage, muffled-gate-scanner) — no implicit any.
- `(opts as any)` → `(opts as { autoOnPromote?: string })`, removing the now-
redundant noExplicitAny suppression.
- useLiteralKeys / useOptionalChain (http, score-utils) via biome safe-fix.
- test name dropped a `${…}` literal.
Verified: biome 0 findings, tsc clean, 1654 tests pass, build clean.
Behavior-identical (regex loops + accumulators are semantically unchanged).
tangletools
approved these changes
May 31, 2026
Contributor
tangletools
left a comment
tangletools
left a comment
There was a problem hiding this comment.
tangletools: zero-lint-debt sweep. Every finding fixed properly (typed-hoisted regex loops, hoisted accumulators, precise cast replacing as-any + redundant suppression dropped) — no blanket suppressions. Verified locally: biome 0, tsc clean, 1654 tests pass, build clean. Behavior-identical. Approved.
Contributor
🔍 Reviewing
|
| Pass | Status | ETA |
|---|---|---|
| opencode DeepSeek v4 Pro | Running | ~5-15 min |
| Kimi Code K2.6 | Running | ~5-15 min |
Agent review running. Reads the actual code. This comment updates in place.
tangletools · #151 · model: kimi-for-coding · started 2026-05-31T16:29:08Z
tangletools
pushed a commit
that referenced
this pull request
May 31, 2026
…en datasets-for-free (#153) Ships #149 (durable RL corpus store), #150 (multi-dimensional RunRecord.raw + corpusText trajectory hook), #151 (zero lint debt), #152 (e2e composition test). npm-only bump (Python RPC client stays pinned at 0.59.1, consistent with the 0.61→0.70 release line); published via pnpm publish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
biome check srcto 0 findings (was 19). Each fixed properly, not suppressed: regex-exec loops → typed-hoisted form (typed loop vars + no assign-in-condition),??=accumulators hoisted,as any→ precise cast (redundant suppression removed), typed lets (Dirent[]/Stats), the 2 complexity auto-fixes. Verified: lint 0 · tsc clean · 1654 tests pass · build clean. Behavior-identical. Senior-quality tech-debt elimination per the directive.