[ForceField] Fix stream functions for some ForceField - #6304
Open
Lucas-TJ wants to merge 11 commits into
Open
Conversation
This commit groups together all fixes related to stream's functions from certain forcefields: - EdgePressureForceField.h - FastTetrahedralCorotationalForceField.h - FastTriangularBendingSprings.h - HexahedralFEMForceField.h - QuadBendingFEMForceField.h - QuadPressureForceField.h - QuadularBendingSprings.h - StandardTetrahedralFEMForceField.h - TetrahedralTensorMassForceField.h - TetrahedronHyperelasticityFEMForceField.h - TrianglePressureForceField.h - TriangularBendingSprings.h - TriangularBiquadraticSpringsForceField.h - TriangularFEMForceField.h - TriangularQuadraticSpringsForceField.h - TriangularTensorMassForceField.h - VectorSpringForceField.h
Lucas-TJ
added
pr: fix
alxbilger
reviewed
Sep 9, 2026
| { | ||
| public: | ||
| EdgeInformation(){} | ||
| Mat DfDx; ///< the edge stiffness matrix |
Contributor
There was a problem hiding this comment.
I think that EdgeInformation and VertexInformation and its instances must be removed. The only usage is a resize, without any further usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello !
For my project, I want to save and load data from components. Same as PR #6128 for TetrahedralCorotationalFEMForceField, I want to save/load data from internal class like "EdgeInformation" or "VertexInformation" etc. These classes have Output and Input stream functions, but they are not correctly implemented.
So, in this PR, I fix the Output stream and Input stream functions for:
(Each function has its own unit test !)
Some additional information :
Thank you !
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if