[Simulation.Core] Differential operations - #6300
Open
alxbilger wants to merge 5 commits into
Open
Conversation
alxbilger
added
pr: status to review
| { | ||
| mappingGraph.algorithms.traverseBottomUp_([&](core::BaseMapping& mapping) | ||
| { | ||
| if (mapping.areForcesMapped() || ignoreMappingFlag) |
Contributor
There was a problem hiding this comment.
Shouldn't the areForcesMapped() methode renamed it seems a rather mechanical term.
I would also invert the ignoreMappingFlag and mapping.areForcesMapped() because the cost for quering mapping.areForceMapped() is much more costly as it is virtual function, that is accessing a Data, so calling a bunch of other virtual function trigger and update the DDG).
Contributor
Author
|
[ci-build][with-all-tests] |
fredroy
reviewed
Sep 10, 2026
fredroy
left a comment
fredroy
left a comment
Contributor
There was a problem hiding this comment.
I guess adding unit tests would be tedious ? 👀
alxbilger
force-pushed
the
differentialoperations
branch
from
September 10, 2026 09:32
3b5e201 to
e2b2f4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces fundamental operations in SOFA, formalized to be physics-independent. The vocabulary no longer uses mechanics terms. The terms are more generic. It is also closer to autodiff frameworks.
The functions are based on the mapping graph. As a consequence, they can be used only in codes where the mapping graph is available. As an example, I use them in
MappingGraphMechanicalOperations. But they should replace all thepropagate*methods inMechanicalOperations. Since those methods are called mainly in integration scheme, I did not want to create conflicts with #6117.To do in a next PR:
propagate*methods inMechanicalOperations.DifferentialOperationswhereverMechanicalOperations::propagate*is used.[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if