[all] Fix compilation warnings - #6226
Open
hugtalbot wants to merge 3 commits into
Open
Conversation
hugtalbot
added
pr: fix
Contributor
Author
|
[ci-build][with-all-tests] |
alxbilger
reviewed
Aug 25, 2026
Comment on lines
+196
to
+197
| static constexpr typename type::Vec6::size_type nbTestedDimensions = | ||
| DataTypes::spatial_dimensions < 3 ? DataTypes::spatial_dimensions : 3; |
Contributor
There was a problem hiding this comment.
Suggested change
| static constexpr typename type::Vec6::size_type nbTestedDimensions = | |
| DataTypes::spatial_dimensions < 3 ? DataTypes::spatial_dimensions : 3; | |
| static constexpr typename type::Vec6::size_type nbTestedDimensions = std::min(DataTypes::spatial_dimensions, 3); |
| { | ||
| const auto& elements = trait::FiniteElement::getElementSequence(*this->l_topology); | ||
| // makes sure the element sequence is available in the topology container | ||
| [[maybe_unused]] const auto& elements = trait::FiniteElement::getElementSequence(*this->l_topology); |
Contributor
|
I confirm that in the collision pipeline the collision if first tested before the projection is done. So whenever we enter this function we know for sure that there is a collision, so no need to check that bool. |
hugtalbot
commented
Sep 2, 2026
Comment on lines
+187
to
+189
| // the returned boolean is not tested here: computeIntersection is only called on pairs for which | ||
| // testIntersection already reported a collision. The call is kept for its outputs: toi and outputTolerance. | ||
| [[maybe_unused]] const auto result = ticcd::edgeEdgeCCD( |
Contributor
Author
There was a problem hiding this comment.
I guess you are suggesting to removing this then @bakpaul
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Massively fix warnings for the pleasure
What was fixed
Some points worth attention
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if