Add Debian standards version metadata - #1222
Merged
cpuguy83 merged 2 commits intoSep 3, 2026
Merged
Conversation
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
The metadata is correctly placed and covered by focused assertions.
Pull request overview
Adds Debian Standards-Version metadata to generated source control stanzas for PMC ingestion.
Changes:
- Defines Standards-Version 4.7.4.
- Emits it once in the source stanza.
- Tests its value and placement.
File summaries
| File | Description |
|---|---|
packaging/linux/deb/debroot.go |
Defines the standards version. |
packaging/linux/deb/template_control.go |
Exposes the version to the template. |
packaging/linux/deb/templates/debian_control.tmpl |
Emits the control field. |
packaging/linux/deb/template_control_test.go |
Verifies value, placement, and occurrence count. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jeremyrickard
approved these changes
Sep 3, 2026
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debian source ingestion requires
Standards-Version, but DALEC-generated control metadata currently omits it.