Conversation
PMC source ingestion requires a Standards-Version field in debian/control. Add it as a package const alongside the other debian/control template constants and wire it through the existing controlWrapper template data conventions. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
The focused implementation correctly emits and tests the required field without unrelated changes.
Pull request overview
Adds the required Debian Standards-Version field to generated control files.
Changes:
- Declares Debian Policy version
4.7.4. - Exposes it through
controlWrapperand the control template. - Tests field value and uniqueness.
File summaries
| File | Description |
|---|---|
packaging/linux/deb/debroot.go |
Defines the policy version constant. |
packaging/linux/deb/template_control.go |
Exposes the version to templates. |
packaging/linux/deb/templates/debian_control.tmpl |
Emits the new control field. |
packaging/linux/deb/template_control_test.go |
Verifies the generated field. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
|
Superseded by #1222. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMC source ingestion requires a
Standards-Versionfield indebian/control. This adds it as a package const inpackaging/linux/deband wires it through the existingcontrolWrappertemplate data conventions, alongsideDebHelperCompat.Scope is limited to the Standards-Version field; no copyright handling or other compliance changes are included.
Adds a focused test (
TestWriteControlStandardsVersion) verifying the generated control content includes exactly oneStandards-Versionfield with the expected value.