Skip to content

Simplify Sha1 shard key extraction and drop its unwrap #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crodas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Simplify Sha1 shard key extraction and drop its unwrap #957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/sharding.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,9 @@ impl Sharder {

hasher.update(key.to_string().as_bytes());

let result = hasher.finalize();
let digest = hasher.finalize();

// Convert the SHA1 hash into hex so we can parse it as a large integer.
let hex = format!("{:x}", result);

// Parse the last 8 bytes as an integer (8 bytes = bigint).
let key = i64::from_str_radix(&hex[hex.len() - 8..], 16).unwrap() as usize;
let key = u32::from_be_bytes([digest[16], digest[17], digest[18], digest[19]]) as usize;

key % self.shards
}
Expand Down