Simplify Sha1 shard key extraction and drop its unwrap#957
Open
crodas wants to merge 1 commit into
Open
Conversation
The Sha1 sharder built a hex string of the whole digest just to parse its tail back into an integer, which introduced a fallible i64::from_str_radix and an .unwrap() that could panic on malformed input. Since a SHA1 digest is already raw bytes, the same value can be read directly. Read the shard key from the last four bytes of the digest with u32::from_be_bytes instead of formatting to hex and parsing the tail with i64::from_str_radix. This removes the allocation, the fallible parse, and the unwrap. The same bytes are selected (the previous code took the last eight hex characters), so shard assignments are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sha1 sharder built a hex string of the whole digest just to parse its tail back into an integer, which introduced a fallible i64::from_str_radix and an .unwrap() that could panic on malformed input. Since a SHA1 digest is already raw bytes, the same value can be read directly.
Read the shard key from the last four bytes of the digest with u32::from_be_bytes instead of formatting to hex and parsing the tail with i64::from_str_radix. This removes the allocation, the fallible parse, and the unwrap. The same bytes are selected (the previous code took the last eight hex characters), so shard assignments are unchanged.