Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/generate-documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
url: ${{ steps.deployment.outputs.page_url }}
runs-on: ubuntu-latest
container:
image: ghcr.io/ponylang/library-documentation-action-v2:release
image: ghcr.io/ponylang/library-documentation-action-v2:nightly
steps:
- name: Checkout
uses: actions/checkout@v6.0.2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
name: Test against recent ponyc release on Linux
runs-on: ubuntu-latest
container:
image: ghcr.io/ponylang/shared-docker-ci-standard-builder-with-openssl-3.6.2:release
image: ghcr.io/ponylang/shared-docker-ci-standard-builder-with-openssl-3.6.2:nightly
steps:
- uses: actions/checkout@v6.0.2
- name: Test
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
needs:
- pre-artefact-creation
container:
image: ghcr.io/ponylang/library-documentation-action-v2:release
image: ghcr.io/ponylang/library-documentation-action-v2:nightly
steps:
- name: Checkout
uses: actions/checkout@v6.0.2
Expand Down
3 changes: 3 additions & 0 deletions .release-notes/fix-compilation-against-ponyc-0.65.0.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## Fix compilation against ponyc 0.65.0

ponyc 0.65.0 changed the standard library `json` package in a way that prevented this library from compiling. github_rest_api now builds against ponyc 0.65.0 and requires ponyc 0.65.0 or later.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Additional API surface and functionality will be added as needed. If you need fu

## Installation

* Requires ponyc 0.64.0 or later
* Requires ponyc 0.65.0 or later
* Install [corral](https://github.com/ponylang/corral)
* `corral add github.com/ponylang/github_rest_api.git --version 0.5.0`
* `corral fetch` to fetch your dependencies
Expand Down
4 changes: 2 additions & 2 deletions github_rest_api/_test_json_converters.pony
Original file line number Diff line number Diff line change
Expand Up @@ -2012,9 +2012,9 @@ class \nodoc\ _TestJsonTypeStringAllArms is UnitTest
.update("f64", F64(3.14))
.update("bool", true)
.update("null", None))
h.assert_eq[String](obj.string(),
h.assert_eq[String](obj.print(),
req.JsonTypeString(nav("obj")))
h.assert_eq[String](arr.string(),
h.assert_eq[String](arr.print(),
req.JsonTypeString(nav("arr")))
h.assert_eq[String]("hello",
req.JsonTypeString(nav("str")))
Expand Down
4 changes: 2 additions & 2 deletions github_rest_api/gist.pony
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ primitive CreateGist
match description
| let d: String => obj = obj.update("description", d)
end
let json = obj.string()
let json = obj.print()

req.JsonRequester.post(creds, url, consume json, r)
p
Expand Down Expand Up @@ -278,7 +278,7 @@ primitive UpdateGist
match description
| let d: String => obj = obj.update("description", d)
end
let json = obj.string()
let json = obj.print()

req.JsonRequester.patch(creds, url, consume json, r)
p
Expand Down
4 changes: 2 additions & 2 deletions github_rest_api/gist_comment.pony
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ primitive CreateGistComment
p,
GistCommentJsonConverter)

let json = JsonObject.update("body", body).string()
let json = JsonObject.update("body", body).print()
req.JsonRequester.post(creds, url, consume json, r)
p

Expand Down Expand Up @@ -180,7 +180,7 @@ primitive UpdateGistComment
p,
GistCommentJsonConverter)

let json = JsonObject.update("body", body).string()
let json = JsonObject.update("body", body).print()
req.JsonRequester.patch(creds, url, consume json, r)
p

Expand Down
2 changes: 1 addition & 1 deletion github_rest_api/issue_comment.pony
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ primitive CreateIssueComment
p,
IssueCommentJsonConverter)

let json = JsonObject.update("body", comment).string()
let json = JsonObject.update("body", comment).print()
req.JsonRequester.post(creds, url, consume json, r)
p

Expand Down
2 changes: 1 addition & 1 deletion github_rest_api/label.pony
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ primitive CreateLabel
match description
| let d: String => obj = obj.update("description", d)
end
let json = obj.string()
let json = obj.print()
req.JsonRequester.post(creds, url, consume json, r)
p

Expand Down
2 changes: 1 addition & 1 deletion github_rest_api/release.pony
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ primitive CreateRelease
obj = obj.update("target_commitish", tc)
end
obj = obj.update("draft", draft).update("prerelease", prerelease)
let json = obj.string()
let json = obj.print()
req.JsonRequester.post(creds, url, consume json, r)
p

Expand Down
4 changes: 2 additions & 2 deletions github_rest_api/request/json.pony
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ primitive JsonTypeString
"""Convert a JsonNav's value to its JSON string representation for error messages."""
fun apply(json: JsonNav): String =>
match \exhaustive\ json.json()
| let o: JsonObject => o.string()
| let a: JsonArray => a.string()
| let o: JsonObject => o.print()
| let a: JsonArray => a.print()
| let s: String => s
| let i: I64 => i.string()
| let f: F64 => f.string()
Expand Down
Loading