Fix compilation against ponyc 0.65.0#129
Merged
Merged
Conversation
ponyc 0.65.0 makes JsonObject and JsonArray no longer Stringable and renames their serialization methods (.string() -> .print()), so the library no longer compiles against it. Rename the affected call sites. Because 0.65.0 is not yet released, CI moves to nightly ponyc until it ships; switching back to release is tracked as a post-release task in ponylang/ponyc#5392.
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ponyc 0.65.0 drops
StringablefromJsonObject/JsonArrayand renames their serialization methods (.string()→.print()), which broke compilation against it. This renames the 11 affected call sites, bumps the README minimum ponyc version to 0.65.0, and adds aFixedrelease note.Since 0.65.0 is not yet released, CI (
pr.yml,generate-documentation.yml,release.yml) moves to nightly ponyc. Switching back to release is tracked as a post-release task in ponylang/ponyc#5392. Thepr.ymljob id/name are intentionally left referencing "release" so branch-protection required-check names are unaffected; the switch-back restores accuracy.Built and tested locally against ponyc
0.64.0-9282cbcc7(the PR #5397 build): 89/89 unit tests pass, examples build.Parked for input (from the lightweight code review — Low/pre-existing, not introduced by this change):
_test_json_converters.pony:2015-2018— theobj/arrassertions compare.print()againstJsonTypeString(...), which also calls.print(), so they verify match-dispatch but not serialization output. Pre-existing (both sides were.string()on main). Worth tightening to literal-JSON assertions, or fine to leave?Note: this library should not be released until ponyc 0.65.0 ships, since main now requires it.