Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/odr/internal/pdf/AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,10 @@ it.

The **reference-output snapshot test** (`test/data/reference-output/`) is the
graphics oracle: each change regenerates it and the diff is reviewed. (An
automated perceptual-diff gate is deferred; see gaps.)
automated perceptual-diff gate is deferred; see gaps.) The snapshot is now the
**odr engine's own output only** — the `pdf2htmlEX`/poppler (`*.pdf-poppler`) and
wvWare (`*.doc-wvware`) cross-engine reference snapshots were removed once the odr
engine was ready to replace them, so the test no longer runs those engines.

## Module layout

Expand Down Expand Up @@ -701,8 +704,9 @@ Link annotations (`/URI` + internal `/GoTo`) already land — see *What works*.
nested text/shadings/patterns inside a tile are skipped (rare).
- **Text clipping**: the clip is not applied to text runs (paths and images are
clipped); text clip render modes (`Tr` 4–7) add nothing to the clip.
- **Perceptual-diff oracle**: the reference-output snapshot test is the current
graphics gate; the automated poppler/pdf.js screenshot-diff is not built.
- **Perceptual-diff oracle**: the reference-output snapshot test (odr output
only) is the current graphics gate; an automated pdf.js screenshot-diff is
not built.
- **Encryption edge cases** (deferred from stage 0 until a real file needs
them): per-stream `/Crypt` filter `Name` overrides, the `EncryptMetadata
false` metadata-stream `Identity` special case, and `Perms` (Algorithm 13)
Expand Down
2 changes: 1 addition & 1 deletion test/data/reference-output/odr-private
2 changes: 1 addition & 1 deletion test/data/reference-output/odr-public
Submodule odr-public updated 43 files
+0 −11 output/doc/11KB.doc-wvware/document.html
+0 −6 output/doc/11KB.doc-wvware/meta.json
+0 −11 output/doc/12KB.doc-wvware/document.html
+0 −6 output/doc/12KB.doc-wvware/meta.json
+0 −11 output/doc/15KB.doc-wvware/document.html
+0 −6 output/doc/15KB.doc-wvware/meta.json
+0 −11 output/doc/170KB.doc-wvware/document.html
+0 −6 output/doc/170KB.doc-wvware/meta.json
+0 −11 output/doc/23KB.doc-wvware/document.html
+0 −6 output/doc/23KB.doc-wvware/meta.json
+0 −69 output/doc/785KB.doc-wvware/document.html
+0 −6 output/doc/785KB.doc-wvware/meta.json
+0 −219 output/doc/SampleDOCFile_1000kb.doc-wvware/document.html
+0 −6 output/doc/SampleDOCFile_1000kb.doc-wvware/meta.json
+0 −29 output/doc/SampleDOCFile_100kb.doc-wvware/document.html
+0 −6 output/doc/SampleDOCFile_100kb.doc-wvware/meta.json
+0 −427 output/doc/SampleDOCFile_2000kb.doc-wvware/document.html
+0 −6 output/doc/SampleDOCFile_2000kb.doc-wvware/meta.json
+0 −47 output/doc/SampleDOCFile_200kb.doc-wvware/document.html
+0 −6 output/doc/SampleDOCFile_200kb.doc-wvware/meta.json
+0 −1,067 output/doc/SampleDOCFile_5000kb.doc-wvware/document.html
+0 −6 output/doc/SampleDOCFile_5000kb.doc-wvware/meta.json
+0 −115 output/doc/SampleDOCFile_500kb.doc-wvware/document.html
+0 −6 output/doc/SampleDOCFile_500kb.doc-wvware/meta.json
+0 −11 output/doc/empty.doc-wvware/document.html
+0 −6 output/doc/empty.doc-wvware/meta.json
+0 −6 output/doc/encrypted.doc-wvware/meta.json
+0 −15 output/doc/file-sample_100kB.doc-wvware/document.html
+0 −6 output/doc/file-sample_100kB.doc-wvware/meta.json
+0 −15 output/doc/file-sample_1MB.doc-wvware/document.html
+0 −6 output/doc/file-sample_1MB.doc-wvware/meta.json
+0 −15 output/doc/file-sample_500kB.doc-wvware/document.html
+0 −6 output/doc/file-sample_500kB.doc-wvware/meta.json
+0 −11 output/doc/sample-doc-file-for-testing-1.doc-wvware/document.html
+0 −6 output/doc/sample-doc-file-for-testing-1.doc-wvware/meta.json
+0 −5,001 output/pdf/Casio_WVA-M650-7AJF.pdf-poppler/document.html
+0 −7 output/pdf/Casio_WVA-M650-7AJF.pdf-poppler/meta.json
+0 −1,323 output/pdf/empty.pdf-poppler/document.html
+0 −7 output/pdf/empty.pdf-poppler/meta.json
+0 −1,816 output/pdf/speisekarte_helmarts.pdf-poppler/document.html
+0 −7 output/pdf/speisekarte_helmarts.pdf-poppler/meta.json
+0 −1,509 output/pdf/style-various-1.pdf-poppler/document.html
+0 −7 output/pdf/style-various-1.pdf-poppler/meta.json
14 changes: 2 additions & 12 deletions test/src/html_output_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -249,18 +249,8 @@ TestParams create_test_params(const TestFile &test_file,
std::vector<TestParams> list_test_params() {
std::vector<TestParams> params;
for (const TestFile &test_file : TestData::test_files()) {
std::vector engines = {DecoderEngine::odr};
if (test_file.type == FileType::portable_document_format) {
engines.push_back(DecoderEngine::poppler);
}
if (test_file.type == FileType::legacy_word_document) {
engines.push_back(DecoderEngine::wvware);
}

for (const DecoderEngine engine : engines) {
params.push_back(
create_test_params(test_file, engine, PdfTextMode::dual_layer));
}
params.push_back(create_test_params(test_file, DecoderEngine::odr,
PdfTextMode::dual_layer));

// PDFs default to `PdfTextMode::dual_layer`. To keep the single-layer path
// under reference-output coverage too, eject an extra `-single` test case
Expand Down
Loading