test: drop pdf2htmlEX/wvWare cross-engine reference comparison#594
Merged
Conversation
The odr engine is ready to replace pdf2htmlEX for PDF and wvWare for legacy .doc. Stop the html_output snapshot test from also generating the poppler and wvware engine outputs, and bump the reference-output submodules to their commits that remove the *.pdf-poppler and *.doc-wvware reference snapshots. The snapshot test is now odr-engine-only. Update the PDF module docs to match. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step toward retiring pdf2htmlEX (PDF) and wvWare (legacy
.doc) now that the odr engine is ready to replace them.What changed
test/src/html_output_test.cpp:list_test_params()no longer adds theDecoderEngine::poppler(PDF) andDecoderEngine::wvware(legacy.doc) cases, so the html_output snapshot test only exercises the odr engine. The odr single-layer (-single) PDF case is unchanged.odr-private: 20 ×*.pdf-poppler/— opendocument-app/OpenDocument.test-private.output#3odr-public: 4 ×*.pdf-poppler/+ 18 ×*.doc-wvware/— Remove pdf2htmlEX (poppler) and wvWare cross-engine reference snapshots OpenDocument.test.output#6src/odr/internal/pdf/AGENTS.md: note the reference-output snapshot is now odr-only.The
DecoderEngine::poppler/wvwareengines and their conan recipes are untouched — this only removes them from the comparison baseline.Note
Merge the two submodule PRs first (or together), since this PR points the submodules at those branch commits.
🤖 Generated with Claude Code