Skip to content

Potential fix for code scanning alert no. 3: Server-side request forgery #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jimklimov wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 3: Server-side request forgery #49

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
563b6b7
Potential fix for code scanning alert no. 3: Server-side request forgery
jimklimov Aug 5, 2026
2bf783f
NutRestProvider: Refactor server host management methods
jimklimov Aug 5, 2026
eb7eb06
Explicitly use `HashSet.clone()` in `getAllowedServerHosts`
jimklimov Aug 5, 2026
9b862ce
Refactor getAllowedServerHosts to return a new HashSet
jimklimov Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions jNutWebAPI/src/main/java/org/networkupstools/jnutwebapi/NutRestProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@

import java.io.IOException;
import java.net.UnknownHostException;
import java.util.Arrays;
import java.util.HashSet;
import java.util.Set;
import java.util.logging.Level;
import java.util.logging.Logger;

Expand All @@ -41,6 +44,31 @@
@Path("/servers")
public class NutRestProvider {

private static final Set<String> ALLOWED_UPSD_HOSTS = new HashSet<String>(Arrays.asList(
"127.0.0.1",
"localhost"
));

public static boolean isAllowedServerHost(String host) {
return host != null && ALLOWED_UPSD_HOSTS.contains(host);
}

public static Set<String> getAllowedServerHosts() {
Set<String> retval = new HashSet<String>();
retval.addAll(ALLOWED_UPSD_HOSTS);
return retval;
}

public static void addAllowedServerHost(String host) {
if (host != null)
ALLOWED_UPSD_HOSTS.add(host);
}

public static void removeAllowedServerHost(String host) {
if (host != null)
ALLOWED_UPSD_HOSTS.remove(host);
}

@GET
public String get() {
return "UPSD connections";
Expand All @@ -64,6 +92,9 @@ public Server(String server) throws IOException, UnknownHostException, NutExcept
if(idx!=-1)
{
String host = server.substring(0, idx);
if (!isAllowedServerHost(host)) {
throw new IllegalArgumentException("Server host is not allowed");
}
String portPart = server.substring(idx+1);
try {
int port = Integer.parseInt(portPart);
Expand All @@ -76,6 +107,9 @@ public Server(String server) throws IOException, UnknownHostException, NutExcept
}
else
{
if (!isAllowedServerHost(server)) {
throw new IllegalArgumentException("Server host is not allowed");
}
client.connect(server, 3493);
}
}
Expand Down