Potential fix for code scanning alert no. 3: Server-side request forgery - #49
Draft
jimklimov wants to merge 4 commits into
Draft
Potential fix for code scanning alert no. 3: Server-side request forgery#49jimklimov wants to merge 4 commits into
jimklimov wants to merge 4 commits into
Conversation
Implement a Set of allowed UPSD host name strings, reject requests to DoS unpermitted systems Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Allow adding/removing/listing entries in the Set of permitted hosts to talk to
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
jimklimov
marked this pull request as ready for review
August 5, 2026 17:10
jimklimov
marked this pull request as draft
August 5, 2026 17:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/networkupstools/jNut/security/code-scanning/3
To fix this without changing intended behavior more than necessary, validate the
serverpath parameter against a strict server-side allowlist before any connection attempt. The best location isNutRestProvider.Server(String server)because it is the trust boundary entry-point and already parses host/port.Implement:
NutRestProvider.Serverconstructor, after parsing host (or using wholeserverwhen no port given), reject non-allowed hosts withIllegalArgumentException.This preserves current functionality for approved hosts while preventing attacker-controlled arbitrary destinations.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.
TODO: This would want a config file or CLI argument support to add permitted hosts on the fly. API to do so is here.