Repository navigation
MathUtils: Fix large isPowerOfTwo values - #34459
Merged
Mugen87 merged 2 commits intoSep 8, 2026
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MathUtils.isPowerOfTwo()uses bitwise operators, which coerce numbers to 32 bits. Large non-powers such as3 * 2 ** 32therefore returntrue, despite the public API documenting a generalnumberinput.Fix
Check for a positive integer and compare it exactly with the nearest numeric power of two. This avoids 32-bit truncation while keeping existing behavior.
Tests
npm run test-unit- 1315 passed, 1 todonpm run test-unit-addons- 385 passednpm run lint-core- passednpm run build- passedgit diff --check- passedCompatibility
The signature is unchanged. Behavior changes only for values the previous 32-bit coercion classified incorrectly.
Related issue
Independently reproduced on current
dev; no matching issue or pull request was found.