Skip to content

[auto-bump] [no-release-notes] dependency by coffeegoddd #3133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coffeegoddd wants to merge 1 commit into from
Closed

[auto-bump] [no-release-notes] dependency by coffeegoddd #3133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require (
github.com/PuerkitoBio/goquery v1.8.1
github.com/cockroachdb/apd/v3 v3.2.3
github.com/cockroachdb/errors v1.7.5
github.com/dolthub/dolt/go v0.40.5-0.20260817234205-86039deef719
github.com/dolthub/dolt/go v0.40.5-0.20260818190141-0c8421b85560

@itoqa itoqa Bot Aug 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View All Evidence

High severity Dependency update breaks the build

What failed: The dependency checks pass, but the project cannot compile because the updated library expects one more argument when cloning the Dolt source. The full test suite therefore stops at a build error instead of running to completion.

Impact · Steps · Stub / mock · Analysis · Why this is likely a bug
  • Severity: High High severity
  • Impact: The application cannot be compiled or released with the updated dependency, so users cannot receive a working build from this change. Reverting the dependency or updating the affected call restores the release path.
  • Steps to Reproduce:
    1. Use the dependency versions committed in go.mod.
    2. Run go mod verify and confirm the modules are valid.
    3. Run go test ./... --count=1.
    4. Observe the compile error in the Dolt source-cloning helper: the clone function receives three arguments but requires four.
  • Stub / mock content: No stubs, mocks, or bypasses were applied for this test in the recorded run.
  • Code Analysis: The repository's go.mod line 9 was changed by this PR from Dolt pseudo-version v0.40.5-0.20260817234205-86039deef719 to v0.40.5-0.20260818190141-0c8421b85560; go.sum lines 249-250 update the matching checksums. The production repository still imports github.com/dolthub/dolt/go/performance/utils/dolt_builder in utils/doltgres_builder/run.go line 13, and Run calls builder.GitCloneBare(parentCtx, tempDir, GithubDoltgres) at line 44. The compiler diagnostic for the selected module reports have (context.Context, string, string) and want (context.Context, string, string, string), confirming an API arity mismatch. Because the changed module selection is the direct trigger and the consumer call was not updated, this is a PR-introduced build break. The targeted remediation is to pass the fourth branch argument required by the new API, using the branch intended by this clone operation; if that API migration is not ready, reverting the single dependency bump is the narrow fallback.
  • Why this is likely a bug: This is a deterministic source-level incompatibility: the selected dependency is verified and matches go.mod, while the compiler rejects a concrete call in application repository code before tests can execute. The failure affects the build and release workflow rather than only a test assertion, and it has a direct, limited fix in the changed dependency integration path. No mocks, route stubs, or test-only code changes caused the mismatch.
Relevant code

go.mod:9

github.com/dolthub/dolt/go v0.40.5-0.20260818190141-0c8421b85560

utils/doltgres_builder/run.go:13-14

builder "github.com/dolthub/dolt/go/performance/utils/dolt_builder"
	"golang.org/x/sync/errgroup"

utils/doltgres_builder/run.go:43-46

// clone doltgres source
err = builder.GitCloneBare(parentCtx, tempDir, GithubDoltgres)
if err != nil {
	return err
Evidence Package
Copy prompt for an agent 
Ito QA identified the following failure during automated PR testing. Please investigate and propose a fix.

**High severity — Dependency update breaks the build**

**What failed:** The dependency checks pass, but the project cannot compile because the updated library expects one more argument when cloning the Dolt source. The full test suite therefore stops at a build error instead of running to completion.

- **Impact:** The application cannot be compiled or released with the updated dependency, so users cannot receive a working build from this change. Reverting the dependency or updating the affected call restores the release path.
- **Steps to reproduce:**
  1. Use the dependency versions committed in go.mod.
  2. Run go mod verify and confirm the modules are valid.
  3. Run go test ./... --count=1.
  4. Observe the compile error in the Dolt source-cloning helper: the clone function receives three arguments but requires four.
- **Stub / mock content:** No stubs, mocks, or bypasses were applied for this test in the recorded run.
- **Code analysis:** The repository's go.mod line 9 was changed by this PR from Dolt pseudo-version v0.40.5-0.20260817234205-86039deef719 to v0.40.5-0.20260818190141-0c8421b85560; go.sum lines 249-250 update the matching checksums. The production repository still imports github.com/dolthub/dolt/go/performance/utils/dolt_builder in utils/doltgres_builder/run.go line 13, and Run calls builder.GitCloneBare(parentCtx, tempDir, GithubDoltgres) at line 44. The compiler diagnostic for the selected module reports have (context.Context, string, string) and want (context.Context, string, string, string), confirming an API arity mismatch. Because the changed module selection is the direct trigger and the consumer call was not updated, this is a PR-introduced build break. The targeted remediation is to pass the fourth branch argument required by the new API, using the branch intended by this clone operation; if that API migration is not ready, reverting the single dependency bump is the narrow fallback.
- **Why this is likely a bug:** This is a deterministic source-level incompatibility: the selected dependency is verified and matches go.mod, while the compiler rejects a concrete call in application repository code before tests can execute. The failure affects the build and release workflow rather than only a test assertion, and it has a direct, limited fix in the changed dependency integration path. No mocks, route stubs, or test-only code changes caused the mismatch.

**Relevant code:**

`go.mod:9`

~~~go
github.com/dolthub/dolt/go v0.40.5-0.20260818190141-0c8421b85560
~~~

`utils/doltgres_builder/run.go:13-14`

~~~go
builder "github.com/dolthub/dolt/go/performance/utils/dolt_builder"
	"golang.org/x/sync/errgroup"
~~~

`utils/doltgres_builder/run.go:43-46`

~~~go
// clone doltgres source
err = builder.GitCloneBare(parentCtx, tempDir, GithubDoltgres)
if err != nil {
	return err
~~~

github.com/dolthub/eventsapi_schema v0.0.0-20260715220557-d9b4a1c6b4d4
github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2
github.com/dolthub/go-mysql-server v0.20.1-0.20260817180248-8ba7438d98bb
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,8 @@ github.com/dolthub/aws-sdk-go-ini-parser v0.0.0-20250305001723-2821c37f6c12 h1:I
github.com/dolthub/aws-sdk-go-ini-parser v0.0.0-20250305001723-2821c37f6c12/go.mod h1:rN7X8BHwkjPcfMQQ2QTAq/xM3leUSGLfb+1Js7Y6TVo=
github.com/dolthub/dolt-mcp v0.3.4 h1:AyG5cw+fNWXDHXujtQnqUPZrpWtPg6FN6yYtjv1pP44=
github.com/dolthub/dolt-mcp v0.3.4/go.mod h1:bCZ7KHvDYs+M0e+ySgmGiNvLhcwsN7bbf5YCyillLrk=
github.com/dolthub/dolt/go v0.40.5-0.20260817234205-86039deef719 h1:SiDEYkRyUq/j5QWDsoL0+TvbJIuhAustFQ7c/8bs9cc=
github.com/dolthub/dolt/go v0.40.5-0.20260817234205-86039deef719/go.mod h1:9kh4fb5yJn2sGjpaHUz+t+AWWEfA1aszvJaHi/f/Dgk=
github.com/dolthub/dolt/go v0.40.5-0.20260818190141-0c8421b85560 h1:0OGoGKEFQSbhpcLWwJYL+U1k9e5HJKJr+mFa0RcNeYA=
github.com/dolthub/dolt/go v0.40.5-0.20260818190141-0c8421b85560/go.mod h1:9kh4fb5yJn2sGjpaHUz+t+AWWEfA1aszvJaHi/f/Dgk=
github.com/dolthub/eventsapi_schema v0.0.0-20260715220557-d9b4a1c6b4d4 h1:0mg9QEFdkkBwJMxvz1tCjHYmfG2iIC6aShj1InDq9/M=
github.com/dolthub/eventsapi_schema v0.0.0-20260715220557-d9b4a1c6b4d4/go.mod h1:SSLraQS/jGLYFgff3vuZ+JbVUct6vyEeMzjLBqWqoyM=
github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2 h1:u3PMzfF8RkKd3lB9pZ2bfn0qEG+1Gms9599cr0REMww=
Expand Down
Loading