[auto-bump] [no-release-notes] dependency by coffeegoddd - #3133
[auto-bump] [no-release-notes] dependency by coffeegoddd#3133coffeegoddd wants to merge 1 commit into
Conversation
|
This PR has been superseded by #3134 |
|
|
SummaryThe run covered core data operations, persistence across reconnects, schema and branch isolation, merges and conflict recovery, transaction handling, concurrent updates and inserts, sequence behavior, and consumer build integration. It exercised both normal workflows and edge cases involving conflicts, failures, and concurrency, with the behavioral checks otherwise healthy. Not safe to merge yet — this PR introduces a high-severity build incompatibility that prevents the application from compiling and blocks release, even though the exercised data and version-control behaviors passed. No unrelated findings change that merge-blocking assessment. Tests run by ItoTip Reply with @itoqa to send us feedback on this test run. |
| github.com/cockroachdb/apd/v3 v3.2.3 | ||
| github.com/cockroachdb/errors v1.7.5 | ||
| github.com/dolthub/dolt/go v0.40.5-0.20260817234205-86039deef719 | ||
| github.com/dolthub/dolt/go v0.40.5-0.20260818190141-0c8421b85560 |
There was a problem hiding this comment.
Dependency update breaks the build
What failed: The dependency checks pass, but the project cannot compile because the updated library expects one more argument when cloning the Dolt source. The full test suite therefore stops at a build error instead of running to completion.
Impact · Steps · Stub / mock · Analysis · Why this is likely a bug
- Severity: High
- Impact: The application cannot be compiled or released with the updated dependency, so users cannot receive a working build from this change. Reverting the dependency or updating the affected call restores the release path.
- Steps to Reproduce:
- Use the dependency versions committed in go.mod.
- Run go mod verify and confirm the modules are valid.
- Run go test ./... --count=1.
- Observe the compile error in the Dolt source-cloning helper: the clone function receives three arguments but requires four.
- Stub / mock content: No stubs, mocks, or bypasses were applied for this test in the recorded run.
- Code Analysis: The repository's go.mod line 9 was changed by this PR from Dolt pseudo-version v0.40.5-0.20260817234205-86039deef719 to v0.40.5-0.20260818190141-0c8421b85560; go.sum lines 249-250 update the matching checksums. The production repository still imports github.com/dolthub/dolt/go/performance/utils/dolt_builder in utils/doltgres_builder/run.go line 13, and Run calls builder.GitCloneBare(parentCtx, tempDir, GithubDoltgres) at line 44. The compiler diagnostic for the selected module reports have (context.Context, string, string) and want (context.Context, string, string, string), confirming an API arity mismatch. Because the changed module selection is the direct trigger and the consumer call was not updated, this is a PR-introduced build break. The targeted remediation is to pass the fourth branch argument required by the new API, using the branch intended by this clone operation; if that API migration is not ready, reverting the single dependency bump is the narrow fallback.
- Why this is likely a bug: This is a deterministic source-level incompatibility: the selected dependency is verified and matches go.mod, while the compiler rejects a concrete call in application repository code before tests can execute. The failure affects the build and release workflow rather than only a test assertion, and it has a direct, limited fix in the changed dependency integration path. No mocks, route stubs, or test-only code changes caused the mismatch.
Relevant code
go.mod:9
github.com/dolthub/dolt/go v0.40.5-0.20260818190141-0c8421b85560utils/doltgres_builder/run.go:13-14
builder "github.com/dolthub/dolt/go/performance/utils/dolt_builder"
"golang.org/x/sync/errgroup"utils/doltgres_builder/run.go:43-46
// clone doltgres source
err = builder.GitCloneBare(parentCtx, tempDir, GithubDoltgres)
if err != nil {
return errEvidence Package
- text/REV-1/build-failure.txt — 2 KB
Copy prompt for an agent
Ito QA identified the following failure during automated PR testing. Please investigate and propose a fix.
**High severity — Dependency update breaks the build**
**What failed:** The dependency checks pass, but the project cannot compile because the updated library expects one more argument when cloning the Dolt source. The full test suite therefore stops at a build error instead of running to completion.
- **Impact:** The application cannot be compiled or released with the updated dependency, so users cannot receive a working build from this change. Reverting the dependency or updating the affected call restores the release path.
- **Steps to reproduce:**
1. Use the dependency versions committed in go.mod.
2. Run go mod verify and confirm the modules are valid.
3. Run go test ./... --count=1.
4. Observe the compile error in the Dolt source-cloning helper: the clone function receives three arguments but requires four.
- **Stub / mock content:** No stubs, mocks, or bypasses were applied for this test in the recorded run.
- **Code analysis:** The repository's go.mod line 9 was changed by this PR from Dolt pseudo-version v0.40.5-0.20260817234205-86039deef719 to v0.40.5-0.20260818190141-0c8421b85560; go.sum lines 249-250 update the matching checksums. The production repository still imports github.com/dolthub/dolt/go/performance/utils/dolt_builder in utils/doltgres_builder/run.go line 13, and Run calls builder.GitCloneBare(parentCtx, tempDir, GithubDoltgres) at line 44. The compiler diagnostic for the selected module reports have (context.Context, string, string) and want (context.Context, string, string, string), confirming an API arity mismatch. Because the changed module selection is the direct trigger and the consumer call was not updated, this is a PR-introduced build break. The targeted remediation is to pass the fourth branch argument required by the new API, using the branch intended by this clone operation; if that API migration is not ready, reverting the single dependency bump is the narrow fallback.
- **Why this is likely a bug:** This is a deterministic source-level incompatibility: the selected dependency is verified and matches go.mod, while the compiler rejects a concrete call in application repository code before tests can execute. The failure affects the build and release workflow rather than only a test assertion, and it has a direct, limited fix in the changed dependency integration path. No mocks, route stubs, or test-only code changes caused the mismatch.
**Relevant code:**
`go.mod:9`
~~~go
github.com/dolthub/dolt/go v0.40.5-0.20260818190141-0c8421b85560
~~~
`utils/doltgres_builder/run.go:13-14`
~~~go
builder "github.com/dolthub/dolt/go/performance/utils/dolt_builder"
"golang.org/x/sync/errgroup"
~~~
`utils/doltgres_builder/run.go:43-46`
~~~go
// clone doltgres source
err = builder.GitCloneBare(parentCtx, tempDir, GithubDoltgres)
if err != nil {
return err
~~~
☕ An Automated Dependency Version Bump PR 👑
Initial Changes
The changes contained in this PR were produced by `go get`ing the dependency.
```bash
go get github.com/dolthub/[dependency]/go@[commit]
```