Skip to content

Fix flaky tests due to change in feature configuration. #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sam Byng (sam-byng) merged 1 commit into from
Aug 11, 2026
+10 −2
Merged

Fix flaky tests due to change in feature configuration. #1277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/test/container-features/containerFeaturesOrder.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,8 @@ describe('Feature Dependencies', function () {
}
});

assert.deepStrictEqual(actual.length, 3);
// The deprecated terraform shorthand resolves to terraform:1, which has github-cli as a hard dependency.
assert.deepStrictEqual(actual.length, 4);
assert.deepStrictEqual(actual,
[
{
Expand All @@ -687,6 +688,12 @@ describe('Feature Dependencies', function () {
greeting: 'howdy'
}
},
{
id: 'ghcr.io/devcontainers/features/github-cli',
options: {
version: 'latest'
}
},
{
id: 'ghcr.io/devcontainers/features/terraform',
options: 'latest'
Expand Down
3 changes: 2 additions & 1 deletion src/test/container-features/e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ describe('Dev Container Features E2E (remote)', function () {
const response = JSON.parse(res.stdout);
console.log(res.stderr);

assert.strictEqual(response.featuresConfiguration?.featureSets.length, 3);
// The deprecated terraform shorthand resolves to terraform:1, which has github-cli as a hard dependency.
assert.strictEqual(response.featuresConfiguration?.featureSets.length, 4);

const dind = response?.featuresConfiguration.featureSets.find((f: FeatureSet) => f?.features[0]?.id === 'docker-in-docker');
assert.exists(dind);
Expand Down