Fix flaky tests due to change in feature configuration. - #1277
Merged
Sam Byng (sam-byng) merged 1 commit intoAug 11, 2026
Conversation
Kaniska (Kaniska244)
marked this pull request as ready for review
August 11, 2026 09:14
Sam Byng (sam-byng)
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two flaky/failing tests caused by a change in feature configuration. The deprecated
terraformshorthand now resolves toterraform:1, which declaresgithub-clias a hard dependency. As a result, the resolved feature set includes an additional feature, so the expected counts in the affected tests needed to be updated.Changes
src/test/container-features/containerFeaturesOrder.test.ts3to4.ghcr.io/devcontainers/features/github-clientry (pulled in transitively viaterraform:1).src/test/container-features/e2e.test.tsfeatureSets.lengthassertion from3to4to account for thegithub-clihard dependency.Why
The
terraformshorthand resolving toterraform:1introducesgithub-clias a hard dependency during feature resolution. The tests were asserting the pre-change counts, causing them to fail intermittently/consistently. This PR realigns the assertions with the current, correct feature resolution behavior.Testing
Feature DependenciesandDev Container Features E2E (remote)tests pass with the updated expectations.Notes