Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## todos #577 +/- ##
==========================================
- Coverage 80.02% 79.85% -0.18%
==========================================
Files 28 28
Lines 12105 12081 -24
==========================================
- Hits 9687 9647 -40
- Misses 2418 2434 +16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
azkrishpy
force-pushed
the
todo/remove-oom-handling
branch
from
September 8, 2026 14:39
275b769 to
374b7e9
Compare
azkrishpy
force-pushed
the
todo/remove-oom-handling
branch
from
September 9, 2026 22:25
f733960 to
6bea455
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
CRT allocators abort on failure rather than returning NULL. They route through
AWS_PANIC_OOM, an unconditionalexit(-1), so every OOM branch guarded by a NULL check was unreachable.Removes those checks and the error paths behind them, and folds acquire-then-zero pairs into
aws_mem_calloc. No assert replaces them: it would be dead in debug and compiled out in release, since the abort happens before control returns.No behavior change. Existing suite passes unchanged.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.