Skip to content

chore: document and pin existing behavior - #578

Merged
azkrishpy merged 2 commits into
todo/remove-oom-handlingfrom
todo/document-behavior
Sep 25, 2026
Merged

azkrishpy merged 2 commits into
todo/remove-oom-handlingfrom
todo/document-behavior

Conversation

@azkrishpy

@azkrishpy azkrishpy commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Issue #, if available: N/A

Description of changes:

Answers TODOs that asked for documentation, and implements two tests that were registered as TODO placeholders.

Documented: websocket ref-count lifetime and CLOSE-frame behavior; why the request-target check deliberately stays looser than RFC7230 5.3 (tightening it would reject targets callers send today, so it needs a minor release); and that releasing a connection while the manager is shutting down is required, not a bug.

Implemented: the two commented-out h2_client_manual_*_window cases, covering window updates that must be ignored when automatic management is on or the stream is not yet activated. The third was already covered by the existing overflow cases.

No behavior change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@azkrishpy
azkrishpy requested a review from a team as a code owner September 3, 2026 04:52
@codecov-commenter

codecov-commenter commented Sep 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.87%. Comparing base (cbcb6b8) to head (e7c6a11).

Additional details and impacted files
@@                     Coverage Diff                      @@
##           todo/remove-oom-handling     #578      +/-   ##
============================================================
+ Coverage                     79.85%   79.87%   +0.02%     
============================================================
  Files                            28       28              
  Lines                         12081    12081              
============================================================
+ Hits                           9647     9650       +3     
+ Misses                         2434     2431       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@azkrishpy
azkrishpy changed the base branch from todos to todo/remove-oom-handling September 8, 2026 14:23
@azkrishpy
azkrishpy force-pushed the todo/document-behavior branch from fbcc1d0 to ed6071b Compare September 8, 2026 14:39
@azkrishpy azkrishpy added the patch ABI backward-compatible (patch release) label Sep 8, 2026
@azkrishpy
azkrishpy force-pushed the todo/document-behavior branch from ed6071b to 9d77f45 Compare September 9, 2026 22:25
@azkrishpy
azkrishpy force-pushed the todo/document-behavior branch from 9d77f45 to e7c6a11 Compare September 24, 2026 22:15
@azkrishpy azkrishpy changed the title Document and pin existing behavior chore: document and pin existing behavior Sep 24, 2026
@azkrishpy
azkrishpy merged commit cf0d414 into main Sep 25, 2026
91 of 92 checks passed
@azkrishpy
azkrishpy deleted the todo/document-behavior branch September 25, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch ABI backward-compatible (patch release)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants