Repository navigation
chore: document and pin existing behavior - #578
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## todo/remove-oom-handling #578 +/- ##
============================================================
+ Coverage 79.85% 79.87% +0.02%
============================================================
Files 28 28
Lines 12081 12081
============================================================
+ Hits 9647 9650 +3
+ Misses 2434 2431 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
azkrishpy
force-pushed
the
todo/document-behavior
branch
from
September 8, 2026 14:39
fbcc1d0 to
ed6071b
Compare
azkrishpy
force-pushed
the
todo/document-behavior
branch
from
September 9, 2026 22:25
ed6071b to
9d77f45
Compare
DmitriyMusatkin
approved these changes
Sep 22, 2026
azkrishpy
force-pushed
the
todo/document-behavior
branch
from
September 24, 2026 22:15
9d77f45 to
e7c6a11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Answers TODOs that asked for documentation, and implements two tests that were registered as TODO placeholders.
Documented: websocket ref-count lifetime and CLOSE-frame behavior; why the request-target check deliberately stays looser than RFC7230 5.3 (tightening it would reject targets callers send today, so it needs a minor release); and that releasing a connection while the manager is shutting down is required, not a bug.
Implemented: the two commented-out
h2_client_manual_*_windowcases, covering window updates that must be ignored when automatic management is on or the stream is not yet activated. The third was already covered by the existing overflow cases.No behavior change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.