Repository navigation
Update the repository for its rename to ably-pubsub-cocoa - #2340
Conversation
The example found the root package at ../../../ably-cocoa, which only exists when the checkout directory is named ably-cocoa. ../.. finds it whatever the directory is called. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ably-sdk-builds-ably-pubsub-cocoa role trusts this repository only under its new name. Same change as #2269 on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After the rename the old URL is the 1.x maintenance copy, so the install snippets name the new URL. A package's identity follows its URL, or its directory for a path dependency, so the package: labels change with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After the rename the old URL is the 1.x maintenance copy, which has no issues or pull requests, so links to them would not resolve. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pull requests, issues and tags these link to stay with the renamed repository. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Workflow and package references .github/workflows/*, Examples/SPM/Package.swift, LiveObjects/Example/.../project.pbxproj |
Workflow role and repository inputs, the SPM product dependency, and the LiveObjects example’s local package path now reference the updated repository or path. |
Repository and installation documentation CONTRIBUTING.md, Docs/*, README.md, LiveObjects/README.md, _AblyPluginSupportPrivate/README.md |
Repository links and package instructions identify ably-pubsub-cocoa. The main README removes manual-install instructions and retains Swift Package Manager guidance. |
Issue links in code and tests Source/*, Source/PrivateHeaders/Ably/ARTInternalLog.h, Test/AblyTests/Tests/* |
Issue and discussion URLs in source comments, header documentation, and test comments now point to the updated repository. Executable code and test logic are unchanged. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Other
Possibly related PRs
- ably/ably-cocoa#2339: Adds the 1.4.1 release entry and repository links; this change updates those links to
ably-pubsub-cocoa.
Merge Risk: 
96373
-
Merge after the repository rename and required AWS trust configuration, as planned. No additional correction is supported by the inspected changes.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly summarizes the main change: updating repository references and configuration for the rename to ably-pubsub-cocoa.Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 10 files. (14 skipped: 14 unsupported.)
-
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit updates links with care,
To the new package name out there.
The workflows point the way,
Swift packages join the play,
Old manual steps hop away.
Comment @coderabbitai help to get the list of available commands.
2.x is distributed through Swift Package Manager only. The section also named a directory that does not exist, the wrong msgpack fork and version, and none of the SDK's other dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge on rename day, after
ably/ably-cocoais renamed toably/ably-pubsub-cocoa(rollout plan §11, step 16). Until then this PR's CI is expected to fail: CI checks the repository out into a directory named after it, and the AWS role below only trusts the new name.Commits
Resolve the LiveObjects example's package by a relative path —
AblyLiveObjectsExample.xcodeprojfound the root package at../../../ably-cocoa, which only exists when the checkout directory is namedably-cocoa.../..works under any name. (Also why Carthage could not build 1.x from a checkout with another name.)Use the ably-pubsub-cocoa AWS role and features name in CI —
docs.yml,liveobjects.yaml,features.yml. Same change as Point CI workflows at the ably-pubsub-cocoa sdk-builds role #2269, which targetsmain.Install from the ably-pubsub-cocoa package — README and LiveObjects README install snippets name the new URL and
package: "ably-pubsub-cocoa";Examples/SPMuses the new identity (for a path dependency it is the directory name). After the rename the old URL is the 1.x maintenance copy.Point repository links and badges at ably/ably-pubsub-cocoa — 41 links in docs, READMEs, and comments in
Source/andTest/(comments only; no code changes). The copy under the old name has no issues or PRs.ably-cocoa-plugin-supportlinks are untouched.Point CHANGELOG links at ably/ably-pubsub-cocoa — 541 PR, issue, tag and compare links. Plain-text mentions of
ably-cocoa(including quoted error messages) are unchanged.Remove the manual install instructions — 2.x ships through Swift Package Manager only, and the section named a directory that does not exist (
ably-cocoa/ably-cocoa), the wrong msgpack fork and version (ably-forks0.2.0; the package usesrvi/msgpack-objective-C0.4.0), and none of the other dependencies (delta-codec-cocoa,_AblyPluginSupportPrivate,ABLY_SUPPORTS_PLUGINS). The Installation intro no longer links to it.Plain-text mentions of "ably-cocoa" as the SDK's former name are left as they are, including the migration guide.
Verified
ably-cocoa,xcodebuild -list -workspace LiveObjects/AblyLiveObjects.xcworkspacefails before commit 1 (Could not resolve package dependencies) and lists the schemes after it.ably-pubsub-cocoa,Examples/SPMresolves andswift build --target SPMIntegrationsucceeds.git diff --checkis clean.Not in this PR
SwiftPackageIndex/PackageListfor the new URL (the README badges point at it).🤖 Generated with Claude Code
Summary by CodeRabbit