Repository navigation
Update supported platforms and outdated install notes - #2345
Conversation
The READMEs list iOS 15, macOS 12 and tvOS 15, as Package.swift does. The README drops the note on 1.2.23's deprecation, and the issue template asks how the SDK was installed instead of about Carthage and CocoaPods. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Platform and installation documentation README.md, LiveObjects/README.md |
The README files now state minimum versions of iOS 15, macOS 12, and tvOS 15. The main README updates Swift Package Manager instructions, adds tvOS to installation guidance, and removes the deprecation notice for versions below 1.2.23. |
Issue template guidance .github/issue_template.md |
The template updates its SDK and platform examples, replaces separate Carthage and CocoaPods questions with an installation-method question, and changes the logging tip to use clientOptions.logLevel. |
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Other
Possibly related PRs
- ably/ably-pubsub-cocoa#2340: Both PRs update README installation instructions and SPM guidance.
- ably/ably-pubsub-cocoa#2341: Both PRs update documentation for the 2.0.0 release, supported platforms, and installation model.
Suggested reviewers: sacoo7, ttypic
Merge Risk: 
Minimal · up to 91f89
-
These documentation updates present no identified merge-blocking risk and are ready to merge after normal checks.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit reads the platform guide,
Then checks the package steps inside.
The issue form has clearer clues,
With logging tips and updated views.
It hops away beneath the moon,
And nibbles docs beside a spoon.
Comment @coderabbitai help to get the list of available commands.
Updates docs that still described 1.x.
Package.swift. They listed 14, 11 and 14.2.0.0andiOS 26.clientOptions.logLevel, sincerealtime.loggerisn't public API in 2.0.🤖 Generated with Claude Code
Summary by CodeRabbit