Skip to content

chore: Update components per new depth spec - #4075

Merged
alanbsmith merged 4 commits into
Workday:prerelease/majorfrom
mannycarrera4:mc-depth
Jul 24, 2026
Merged

chore: Update components per new depth spec#4075
alanbsmith merged 4 commits into
Workday:prerelease/majorfrom
mannycarrera4:mc-depth

Conversation

@mannycarrera4

@mannycarrera4 mannycarrera4 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes: #4057

Release Category

Components

Release Note

Updates Canvas Kit components to use the revised system.depth token scale from the Sana Canvas depth spec. Several overlay and surface components were using depth values that no longer match the intended elevation hierarchy.

Banner — adds boxShadow: system.depth[5] (previously had no box-shadow)
Modal.Card — system.depth[5] → system.depth[6]
Popup.Card — system.depth[3] → system.depth[4]
Toast — system.depth[3] → system.depth[5]
Tooltip — system.depth[2] → system.depth[3]


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updates component shadow depth tokens for Banner, Modal.Card, Popup.Card, Toast, and Tooltip, and documents the v16 visual changes in the upgrade guide.

Changes

Visual style updates

Layer / File(s) Summary
Component shadow tokens
modules/react/{banner,modal,popup,toast,tooltip}/lib/*
Banner adds system.depth[5]; Modal.Card, Popup.Card, Toast, and Tooltip update their shadow depth tokens.
Upgrade guide documentation
modules/docs/mdx/16.0-UPGRADE-GUIDE.mdx
Adds Banner, Modal, and Popup navigation entries and documents the updated component visual specifications.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: josh-bagwell, williamjstanton

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR does not address #1234's SidePanel RTL fixes; it changes depth-spec styling/docs in unrelated components instead. Update modules/preview-react/side-panel/lib/SidePanel.tsx to fix ToggleButton icon position and direction for RTL, and validate it in the docs examples.
Out of Scope Changes check ⚠️ Warning Most changes are unrelated to #1234, including depth-spec updates in Banner, Modal, Popup, Toast, Tooltip, and the upgrade guide. Remove unrelated depth-spec and documentation edits, or split them into a separate PR aligned to the actual issue scope.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: updating components to match the new depth spec.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cypress

cypress Bot commented Jul 20, 2026

Copy link
Copy Markdown

Workday/canvas-kit    Run #11326

Run Properties:  status check passed Passed #11326  •  git commit 23a391680a ℹ️: Merge 062b1af0841cec374842fe872189b20d23bfaefa into 015bc0395248b6243fe302947a22...
Project Workday/canvas-kit
Branch Review mc-depth
Run status status check passed Passed #11326
Run duration 03m 08s
Commit git commit 23a391680a ℹ️: Merge 062b1af0841cec374842fe872189b20d23bfaefa into 015bc0395248b6243fe302947a22...
Committer Manuel Carrera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 17
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 809
View all changes introduced in this branch ↗︎
UI Coverage  19.54%
  Untested elements 1534  
  Tested elements 370  
Accessibility  99.47%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 72  

@mannycarrera4
mannycarrera4 marked this pull request as ready for review July 23, 2026 17:39
@mannycarrera4 mannycarrera4 added the ready for review Code is ready for review label Jul 23, 2026
- Type level is now `subtext.lg` (previously `subtext.md`).
- Padding and spacing have been adjusted to accommodate the new styling.

### Modal

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Do we want to move Menu & Modal after Menu's upgrade guide details so that the TOC's ordering is correct?

@alanbsmith
alanbsmith enabled auto-merge (squash) July 24, 2026 14:38
@alanbsmith
alanbsmith merged commit 8039cd1 into Workday:prerelease/major Jul 24, 2026
21 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ready for review Code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants