chore: Update components per new depth spec - #4075
Merged
Merged
Conversation
📝 WalkthroughWalkthroughUpdates component shadow depth tokens for Banner, Modal.Card, Popup.Card, Toast, and Tooltip, and documents the v16 visual changes in the upgrade guide. ChangesVisual style updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
mc-depth
|
| Run status |
|
| Run duration | 03m 08s |
| Commit |
|
| Committer | Manuel Carrera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
17
|
|
|
0
|
|
|
809
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.54%
|
|
|---|---|
|
|
1534
|
|
|
370
|
Accessibility
99.47%
|
|
|---|---|
|
|
5 critical
5 serious
0 moderate
2 minor
|
|
|
72
|
mannycarrera4
marked this pull request as ready for review
July 23, 2026 17:39
sheelah
reviewed
Jul 23, 2026
| - Type level is now `subtext.lg` (previously `subtext.md`). | ||
| - Padding and spacing have been adjusted to accommodate the new styling. | ||
|
|
||
| ### Modal |
Contributor
There was a problem hiding this comment.
nit: Do we want to move Menu & Modal after Menu's upgrade guide details so that the TOC's ordering is correct?
sheelah
approved these changes
Jul 23, 2026
alanbsmith
enabled auto-merge (squash)
July 24, 2026 14:38
This was referenced Jul 24, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #4057
Release Category
Components
Release Note
Updates Canvas Kit components to use the revised system.depth token scale from the Sana Canvas depth spec. Several overlay and surface components were using depth values that no longer match the intended elevation hierarchy.
Banner — adds boxShadow: system.depth[5] (previously had no box-shadow)
Modal.Card — system.depth[5] → system.depth[6]
Popup.Card — system.depth[3] → system.depth[4]
Toast — system.depth[3] → system.depth[5]
Tooltip — system.depth[2] → system.depth[3]
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)