fix: Update icon size in menu - #4086
Merged
alanbsmith merged 6 commits intoJul 24, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughUpgrade guides received Markdown, codemod, Canvas Tokens, and v16 visual-update documentation changes. Menu icons now render at medium size, and MDX import cleanup conditionally preserves spacing. ChangesUpgrade and Menu updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@modules/docs/llm/upgrade-guides/12.0-UPGRADE-GUIDE.md`:
- Line 107: Separate each malformed shell code-block opening fence from the
preceding sentence by placing it on its own line. Apply this in
modules/docs/llm/upgrade-guides/12.0-UPGRADE-GUIDE.md lines 107 and 801-802;
modules/docs/llm/upgrade-guides/13.0-UPGRADE-GUIDE.md lines 65 and 489-490;
modules/docs/llm/upgrade-guides/14.0-UPGRADE-GUIDE.md lines 120 and 1104-1105;
modules/docs/llm/upgrade-guides/15.0-UPGRADE-GUIDE.md lines 99-101 and
1133-1135; and modules/docs/llm/upgrade-guides/16.0-UPGRADE-GUIDE.md line 82.
In `@modules/docs/llm/upgrade-guides/16.0-UPGRADE-GUIDE.md`:
- Line 422: Update the detailed Menu icon sizing paragraphs in
modules/docs/llm/upgrade-guides/16.0-UPGRADE-GUIDE.md at lines 422-422 and
modules/docs/mdx/16.0-UPGRADE-GUIDE.mdx at lines 428-428 so Menu.Item.Icon
documents the md/20px default, while Menu.Option.Icon remains separately
documented as xs/16px if applicable; keep both guides consistent with
MenuItem.tsx.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: f2dca1ca-22cd-42a0-ae44-d3c9e2241eed
📒 Files selected for processing (8)
modules/docs/llm/upgrade-guides/12.0-UPGRADE-GUIDE.mdmodules/docs/llm/upgrade-guides/13.0-UPGRADE-GUIDE.mdmodules/docs/llm/upgrade-guides/14.0-UPGRADE-GUIDE.mdmodules/docs/llm/upgrade-guides/15.0-UPGRADE-GUIDE.mdmodules/docs/llm/upgrade-guides/16.0-UPGRADE-GUIDE.mdmodules/docs/mdx/16.0-UPGRADE-GUIDE.mdxmodules/react/menu/lib/MenuItem.tsxutils/mdx-upgrades-2-md.js
added 2 commits
July 24, 2026 10:29
Workday/canvas-kit
 |
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
mc-menu-icon-size
|
| Run status |
|
| Run duration | 02m 36s |
| Commit |
|
| Committer | Manuel Carrera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
17
|
 |
0
|
 |
809
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.54%
|
|
|---|---|
|
|
1534
|
|
|
370
|
Accessibility
99.47%
|
|
|---|---|
|
|
5 critical
5 serious
0 moderate
2 minor
|
|
|
71
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #4077
Release Category
Components
Release Note
Update Menu Icon size to 20x20
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)
Summary by CodeRabbit
Documentation
Enhancements
md(20px / 1.25rem) for Menu item icons and MenuOption selected checkmarks.