php-in-php: route time() through TimeJitHelper; drop LibcExtern time (#30332) - #30336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time()throughJitVmHelperLink→TimeJitHelper(@\time) with NestedJIT thinJitTimeKernellibctime(2)leaf (microtime php-in-php: StringMicrotime libc gettimeofday LLVM → JitVmHelperLink + MicrotimeJitHelper PHP (gettimeofday #13764 shape) #29405 / gethostname php-in-php: GethostnameJitHelper → @gethostname NestedJIT leaf; delete phpc_gethostname_kernel (re-#29313 / putenv #29334) #29364 shape).'time'fromLibcExtern(TouchLibcRuntime +JitTimeKerneldeclare module-locally).C / ABI shrink
lib/JIT/LibcExtern.php: removed'time' =>decl (−1 libc surface row).ext/standard/JitDate.php: removed inlinelookupFunction('time')body (−~10 lines LLVM call path).php-src reference
ext/date/php_date.c—PHP_FUNCTION(time)PHP implementation
lib/JIT/Builtin/StringTime.php— bridgeext/standard/TimeJitHelper.php— helper peelext/standard/JitTimeKernel.php— NestedJIT leafTest plan / verification (exact)
Not covered: full
bootstrap-selfhost-linknative gen-0 (falls back to Zend — #28998 exclusive r4);north-star5-verify --strict.Made with Cursor