Skip to content

fix: Render at-mentioned chips as @labels in task titles#2268

Closed
charlesvien wants to merge 2 commits into
graphite-base/2268from
fix/at-mention-directory-titles
Closed

fix: Render at-mentioned chips as @labels in task titles#2268
charlesvien wants to merge 2 commits into
graphite-base/2268from
fix/at-mention-directory-titles

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented May 20, 2026

Problem

At-mentioned directories (and other chip types) rendered as raw XML like <folder path="products/agentic_tests" /> in task titles instead of human-readable text.

Closes #2172

Changes

  1. Add xmlToPlainText helper composing xmlToContent + contentToPlainText
  2. Use it in the task-creation saga so every chip type renders as @label
  3. Drop unused createFileTagRegex import from the saga
  4. Update attachment-only saga test (now shows @tmp/code.ts instead of "Reading attachment…")
  5. Add folder-mention regression test plus xmlToPlainText unit tests

How did you test this?

Manually

Publish to changelog?

@charlesvien charlesvien changed the title Render at-mentioned chips as @labels in task titles fix: Render at-mentioned chips as @labels in task titles May 20, 2026
Copy link
Copy Markdown
Member Author

charlesvien commented May 20, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant