Skip to content

fix: Make file references in agent messages clickable in command center#2271

Merged
charlesvien merged 2 commits into
mainfrom
05-20-command-center-clicking-file-ref-does-nothing
May 21, 2026
Merged

fix: Make file references in agent messages clickable in command center#2271
charlesvien merged 2 commits into
mainfrom
05-20-command-center-clicking-file-ref-does-nothing

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented May 20, 2026

Problem

In Command Center cells, file references in agent messages (e.g. resources.md) were silently disabled because the link components read useTaskStore.selectedTaskId, which is null when notask is selected from the sidebar.

Closes #2170

Changes

  1. Add SessionTaskIdContext exposing the active conversation's taskId
  2. Provide it from ConversationView so every message renders against its own task
  3. Read taskId from the context in InlineFileLink and BareFileLink
  4. Read taskId from the context in FileMentionChip

How did you test this?

Manually

Publish to changelog?

no

@charlesvien charlesvien changed the title Make file references in agent messages clickable fix: Make file references in agent messages clickable in command center May 20, 2026
@charlesvien charlesvien force-pushed the 05-20-command-center-clicking-file-ref-does-nothing branch from 99460f7 to b5ecbfb Compare May 21, 2026 00:07
@charlesvien charlesvien force-pushed the 05-20-render_at-mentioned_chips_as_labels_in_task_titles branch from 1b02670 to 0b8803b Compare May 21, 2026 00:07
@charlesvien charlesvien force-pushed the 05-20-command-center-clicking-file-ref-does-nothing branch from b5ecbfb to 8298610 Compare May 21, 2026 00:43
@charlesvien charlesvien marked this pull request as ready for review May 21, 2026 00:52
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 21, 2026

Reviews (1): Last reviewed commit: "remove unused selectedTaskId from task s..." | Re-trigger Greptile

@charlesvien charlesvien force-pushed the 05-20-command-center-clicking-file-ref-does-nothing branch from 64a785b to 41013d4 Compare May 21, 2026 02:10
@charlesvien charlesvien force-pushed the 05-20-render_at-mentioned_chips_as_labels_in_task_titles branch 2 times, most recently from 2f5cde6 to bef2ea7 Compare May 21, 2026 03:44
@charlesvien charlesvien force-pushed the 05-20-command-center-clicking-file-ref-does-nothing branch from 41013d4 to 50e7887 Compare May 21, 2026 03:44
@graphite-app graphite-app Bot changed the base branch from 05-20-render_at-mentioned_chips_as_labels_in_task_titles to graphite-base/2271 May 21, 2026 07:54
@charlesvien charlesvien force-pushed the 05-20-command-center-clicking-file-ref-does-nothing branch from 50e7887 to 4f03bdb Compare May 21, 2026 18:12
@charlesvien charlesvien force-pushed the graphite-base/2271 branch from bef2ea7 to 4c5bf3a Compare May 21, 2026 18:12
@graphite-app graphite-app Bot changed the base branch from graphite-base/2271 to main May 21, 2026 18:12
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 21, 2026

Merge activity

  • May 21, 6:12 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@charlesvien charlesvien merged commit 93652e1 into main May 21, 2026
11 of 16 checks passed
@charlesvien charlesvien deleted the 05-20-command-center-clicking-file-ref-does-nothing branch May 21, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command Center: clicking file references does nothing

2 participants