Skip to content

[18.0][IMP] helpdesk_ticket_partner_response to skip auto replies - #1053

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
Nitrokey:18.0-imp-helpdesk_ticket_partner_response-skip-auto-reply
Jul 29, 2026
Merged

[18.0][IMP] helpdesk_ticket_partner_response to skip auto replies#1053
OCA-git-bot merged 1 commit into
OCA:18.0from
Nitrokey:18.0-imp-helpdesk_ticket_partner_response-skip-auto-reply

Conversation

@jans23

@jans23 jans23 commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Together with #1051 this avoids updating the ticket stage when receiving an automatic email.

@OCA-git-bot

OCA-git-bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Hi @peluko00,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added series:18.0 mod:helpdesk_ticket_partner_response Module helpdesk_ticket_partner_response labels Jun 25, 2026
@jans23 jans23 mentioned this pull request Jun 25, 2026
Open
@jans23

jans23 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@peluko00 please have a look. Thanks.

@peluko00

peluko00 commented Jul 2, 2026

Copy link
Copy Markdown

Add tests please @jans23

@jans23
jans23 force-pushed the 18.0-imp-helpdesk_ticket_partner_response-skip-auto-reply branch from 44be112 to 77c57f3 Compare July 2, 2026 11:29
@jans23

jans23 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@peluko00 tests added as requested.

peluko00
peluko00 approved these changes Jul 2, 2026
View reviewed changes

@peluko00 peluko00 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jans23

jans23 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

@pedrobaeza could this be merged too, please?

@pedrobaeza pedrobaeza changed the title [IMP] helpdesk_ticket_partner_response to skip auto replies [18.0][IMP] helpdesk_ticket_partner_response to skip auto replies Jul 10, 2026
@pedrobaeza pedrobaeza added this to the 18.0 milestone Jul 10, 2026
@pedrobaeza

pedrobaeza commented Jul 10, 2026

Copy link
Copy Markdown
Member

Missing a second review

IriaAlonso
IriaAlonso reviewed Jul 28, 2026
View reviewed changes

@IriaAlonso IriaAlonso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jans23 Please bump module version

@jans23
jans23 force-pushed the 18.0-imp-helpdesk_ticket_partner_response-skip-auto-reply branch 2 times, most recently from 1922b67 to 2e2c820 Compare July 28, 2026 11:59
@jans23

jans23 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@IriaAlonso incremented module version as requested.

@IriaAlonso

IriaAlonso commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@jans23 what did you do in the last push? I mean, on the commit 1922b67 you updated the module version, than on the commit 2e2c820 you delete it

@jans23
jans23 force-pushed the 18.0-imp-helpdesk_ticket_partner_response-skip-auto-reply branch from 2e2c820 to c8a6715 Compare July 29, 2026 12:21
@jans23

jans23 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@IriaAlonso Seems I lost it during rebase. Now with incremented version number.

IriaAlonso
IriaAlonso reviewed Jul 29, 2026
View reviewed changes
Comment thread helpdesk_ticket_partner_response/__manifest__.py Outdated
@jans23
jans23 force-pushed the 18.0-imp-helpdesk_ticket_partner_response-skip-auto-reply branch from c8a6715 to 8d2dd86 Compare July 29, 2026 12:46
IriaAlonso
IriaAlonso approved these changes Jul 29, 2026
View reviewed changes

@IriaAlonso IriaAlonso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot

OCA-git-bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jans23

jans23 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@pedrobaeza Now this got the two approvals.

pedrobaeza
pedrobaeza reviewed Jul 29, 2026
View reviewed changes

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One review should be from a PSC/maintainer, but let's continue this time.

Merging with nobump as the PR contains the version bumpep

/ocabot merge nobump

Comment thread helpdesk_ticket_partner_response/__manifest__.py
"name": "Helpdesk Ticket Partner Response",
"summary": "Change ticket stage when partner response",
"version": "18.0.1.1.2",
"version": "18.0.1.2.0",

@pedrobaeza pedrobaeza Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid to change manually the module version, or it can conflict

@OCA-git-bot

OCA-git-bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1053-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1053-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 2a1c2ca into OCA:18.0 Jul 29, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at cf04d92. Thanks a lot for contributing to OCA. ❤️

@jans23 jans23 mentioned this pull request Jul 29, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments
+2 more reviewers
@peluko00 peluko00 peluko00 approved these changes
@IriaAlonso IriaAlonso IriaAlonso approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:helpdesk_ticket_partner_response Module helpdesk_ticket_partner_response ready to merge series:18.0

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jans23 @OCA-git-bot @peluko00 @pedrobaeza @IriaAlonso