Skip to content

[18.0][ADD] helpdesk_ticket_partner_response_mail_autogenerated_header - #1051

Open
jans23 wants to merge 1 commit into
OCA:18.0from
Nitrokey:18.0-add-helpdesk_ticket_partner_response_mail_autogenerated_header
Open

[18.0][ADD] helpdesk_ticket_partner_response_mail_autogenerated_header#1051
jans23 wants to merge 1 commit into
OCA:18.0from
Nitrokey:18.0-add-helpdesk_ticket_partner_response_mail_autogenerated_header

Conversation

@jans23

@jans23 jans23 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

When an auto-generated email (e.g. an out-of-office reply carrying
Auto-Submitted: auto-replied or X-Auto-Response-Suppress: AutoReply/All)
is received on an existing helpdesk ticket, the ticket stage must not be
advanced automatically to avoid treating bot replies as genuine partner responses.

This module integrates helpdesk_ticket_partner_response with
mail_autogenerated_header by overriding _skip_ticket_stage_update_from_autoreply
to detect such headers and suppress the stage update.

If follows a similar approach as #1050

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @peluko00,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added series:18.0 mod:helpdesk_ticket_partner_response Module helpdesk_ticket_partner_response mod:helpdesk_ticket_partner_response_mail_au f62c3 Module helpdesk_ticket_partner_response_mail_autogenerated_header labels Jun 22, 2026
@jans23
jans23 force-pushed the 18.0-add-helpdesk_ticket_partner_response_mail_autogenerated_header branch from e2f3c8d to b7456dd Compare June 22, 2026 14:51
@jans23
jans23 force-pushed the 18.0-add-helpdesk_ticket_partner_response_mail_autogenerated_header branch from b7456dd to 74e743d Compare June 22, 2026 15:00
@jans23

jans23 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@peluko00 it would be great if you could review this (small) module.

@peluko00

peluko00 commented Jun 25, 2026

Copy link
Copy Markdown

Why do you need to modify the base module when you add a new module?

@jans23

jans23 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

This is to skip sending the response email if an auto-reply arrived which is functionality of the base module (helpdesk_ticket_partner_response).

@peluko00

Copy link
Copy Markdown

Please separate this [IMP] in another pr

@jans23
jans23 force-pushed the 18.0-add-helpdesk_ticket_partner_response_mail_autogenerated_header branch from 74e743d to 0f145b7 Compare June 25, 2026 10:06
@OCA-git-bot OCA-git-bot removed the mod:helpdesk_ticket_partner_response Module helpdesk_ticket_partner_response label Jun 25, 2026
@jans23

jans23 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Done in #1053.

@jans23
jans23 force-pushed the 18.0-add-helpdesk_ticket_partner_response_mail_autogenerated_header branch from 0f145b7 to 5a9e300 Compare July 29, 2026 14:43
@jans23

jans23 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@peluko00 now this goes green. Could you review, please?

@jans23 jans23 changed the title [ADD] helpdesk_ticket_partner_response_mail_autogenerated_header [18.0][ADD] helpdesk_ticket_partner_response_mail_autogenerated_header Jul 29, 2026
@jans23

jans23 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

@peluko00 please check. Thanks.

@peluko00 peluko00 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jans23

jans23 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@marcelsavegnago could you review this too, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:helpdesk_ticket_partner_response_mail_au f62c3 Module helpdesk_ticket_partner_response_mail_autogenerated_header series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants