Delegate the module skill to the developer manual - #9
Closed
stephdl wants to merge 1 commit into
Closed
Conversation
stephdl
marked this pull request as draft
August 26, 2026 12:04
The skill cited no upstream documentation across its 630 lines. Add a delegation table for the 17 docs/modules pages, and a pointer to the agent Python package, which ships with core and has no reference page anywhere. The description advertised areas rather than problems, so questions it answers matched nothing: a routing probe on secret storage went to blind rediscovery. It also claimed ns8-core, whose layout fires the same structural triggers one directory deeper.
stephdl
force-pushed
the
ns8-module-delegation
branch
from
August 31, 2026 08:54
e3d2663 to
fccbfb8
Compare
Contributor
Author
|
Superseded by #13. This branch targeted the skill before #10 split it into a router plus reference files, so it no longer merges. #13 carries the delegation table and the agent package note, rebuilt on current main: the table moved into references/platform-contracts.md to keep the router cheap, the description hunk is gone because #10 already rewrote it, and the deploy loop is gone because nethserver-admin and the new_module page cover it. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skill cited no upstream documentation across its 630 lines. It paraphrases contracts that
docs/modules/specifies, and omits what the manual covers better: the build and deploy loop is written down in full indocs/modules/new_module.mdand was never mentioned.Three changes.
A delegation table for the 17
docs/modules/pages, so a reader reaches the specification instead of the paraphrase.A pointer to the
agentPython package, which ships with core, reaches the import path through apypkg.pthfile rather thanPYTHONPATH, and has no reference page anywhere — 19 of its 45 public functions appear in no document. The section names the domains the package covers and gives the grep that regenerates the index, rather than listing members that churn.A description that no longer claims ns8-core, whose
imageroot/,ui/andorg.nethserver.*labels fire the same structural triggers one directory deeper, and that advertises the questions the skill answers rather than the areas it covers. That second point was measured: a routing probe asking where to store a generated password went to blind rediscovery although the skill carries the full pattern. It reaches the skill now.