Delegate the module skill's platform contracts to the developer manual - #13
Merged
Conversation
The manual specifies certificates, port allocation, network, metadata, rootless mode and certification. Point at the page instead of restating it, and record that the agent package ships with the core image so a helper that already exists is not written twice. Keep the router untouched apart from one map row: the table and the page name pattern live in the reference file, loaded only when needed.
The grep assumed shell access to a node. A module repo has no copy of the package, so point at the ns8-stable tag of ns8-core, which tracks the released core a node runs, and keep the node path as the fallback.
The comment repeated what the paragraph above already states about installing nothing locally. Keep only the ref choice.
Listing the 45 public functions by domain costs 200 tokens and answers the common question offline, where fetching the source costs 8500 and a network round trip. The URL stays for a signature or a missing name, out of a bash block so it does not read as a step.
gsanchietti
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The skill paraphrased contracts that the
docs/modules/tree ofNethServer/ns8-corealready specifies, and said nothing about theagentpackage every action imports.references/platform-contracts.mddelegates to the 17 manual pages, one line each, with the URL pattern given once.references/backend.mdgains the provenance of the package — it ships in the core image and reachesimport agentthrough apypkg.pth, so nothing resolves it in a module repo — plus an index of its 45 public functions grouped by domain. The index costs about 200 tokens and answers offline; fetching the source costs 8500 and a network call. The URL stays for a signature or a missing name, outside a bash block so it does not read as a step.The router grows by one map row of 22 words, naming only the subjects no other row routes.
Dropped on purpose: the deploy loop, since
add-moduleis already innethserver-adminandbuildahis what thenew_modulepage is for, and thedescriptionrewrite, since #10 has since done it better.Related issue
None. Supersedes #9, which no longer merges since #10 split the skill into a router plus references.
How to test
Open a page from the table, for instance
https://nethserver.github.io/ns8-core/modules/port_allocation/, and confirm the pattern resolves. Compare the index againstcurl -s https://raw.githubusercontent.com/NethServer/ns8-core/ns8-stable/core/imageroot/usr/local/agent/pypkg/agent/__init__.py | grep '^def '— 47 definitions, the two underscore-prefixed ones excluded.Dependencies
None.