Npi 3794 Restructure Clock comparison and sisre calculation argument order#77
Closed
treefern wants to merge 2 commits into
Closed
Npi 3794 Restructure Clock comparison and sisre calculation argument order#77treefern wants to merge 2 commits into
treefern wants to merge 2 commits into
Conversation
…ions, plus add clarifying comment for some Numpy custom operator usage
…ument order consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed: superseded by #80
As brought to light by this PR some time ago, the order of arguments to some of our diff functions is inconsistent.
This PR attempts to improve internal consistency.