NPI-3793 Fix misleading operator use on sets#76
Closed
treefern wants to merge 1 commit into
Closed
Conversation
…ions, plus add clarifying comment for some Numpy custom operator usage
Collaborator
Author
|
Closed this PR as the relevant code is downstream and will be merged in via #77 |
ronaldmaj
deleted the
NPI-3793-improve-misleading-operator-usage-on-sets
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some instances where a bitwise AND operator appears to be used on structures for which it does not make sense.
Plus add clarifying comment for some Numpy custom operator usage.
This PR was split out from work done to restructure clk comparison and sisre calculation. TODO: a small fix is needed.