Extend expression planners for Snowflake compatibility - #47
Merged
osipovartem merged 30 commits intoSep 3, 2026
Conversation
Expose input schema to scalar expression planners
Plan qualified wildcard options in function arguments
…nto snowflake-decimal-literals
Add optional decimal literal normalization
Fix wildcard keys for USING outer joins
Avoid target schema propagation into INSERT SELECT
|
ack |
Do not treat volatile expressions as constants
Preserve rows when sorting zero-column batches
Fall back to floats for out-of-range decimal literals
Preserve Snowflake PIVOT column names
Apply PIVOT aliases before schema validation
Collaborator
Author
|
All required checks are green, including the full Rust and extended-test matrices. The focused decimal division, AVG rounding, trailing-zero normalization, and out-of-range literal tests also pass locally. @Vedin Could you submit the acknowledgement as an approving GitHub review? Branch protection still reports |
Vedin
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alias.* EXCLUDE (...)Float64when a fractional/scientific literal exceeds the Decimal256 rangeh2to 0.4.16 forRUSTSEC-2026-0258This PR synchronizes the complete DF55 integration stack used by Rustice into the canonical
embucket-sync-df55.0.0branch. It contains the changes previously reviewed in #48 through #55.Compatibility
The planner hooks and decimal normalization are opt-in, so default DataFusion parsing and expression planning remain unchanged. The remaining changes fix concrete planner/execution correctness cases exercised by Rustice.
With decimal parsing and trailing-zero normalization enabled:
10.00plans asDECIMAL(2, 0)10.10plans asDECIMAL(3, 1)0.00100plans asDECIMAL(4, 3)1.2300e2plans asDECIMAL(3, 0)Float64; oversized integer literals remain errorsValidation
options.sltrun after refreshing the three fallback expectationscargo fmt --all -- --check