Apply PIVOT aliases before schema validation - #57
Merged
osipovartem merged 1 commit intoSep 3, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes a Snowflake compatibility gap where chained
PIVOTclauses produce duplicate intermediate literal column names before the outer table alias can rename them.Rationale for this change
Snowflake supports assigning a complete column alias list to the result of chained
PIVOTclauses. DataFusion currently builds the second aggregate first, rejects its duplicate output names, and never reachesapply_table_alias.What changes are included in this PR?
Are there any user-facing changes?
Queries such as
... PIVOT(...) PIVOT(...) AS p(col1, col2, ...)now plan and execute when the explicit aliases make the final schema unambiguous.How was this tested?
cargo +stable test -p datafusion-sql --lib --offline: 92 passedcargo +stable test -p datafusion --test core_integration pivot_unpivot --offline: 3 passedcargo +stable clippy -p datafusion-sql --all-targets --offline -- -D warningscargo +stable fmt --all --checkStacked on #47, which contains the DF55 Snowflake compatibility patches.