Track more text-related CSS properties on /status/css - #37
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the text-related properties covered by the "Winkin, Parley and Chrome" text specimen comparison that
/status/csswasn't tracking yet. Properties used on 1% of pages or fewer (Chrome Status) are left out. Each group's new entries go at the end, ordered by popularity.font-optical-sizing,font-synthesis(+-weight/-style/-small-caps),font-kerning,font-size-adjusttext-orientationbox-decoration-break,text-align-last,text-justifyStatuses come from blitz
main(stylo_to_parley.rsandblitz-paint):text-align-lastis Yes: it was implemented in Implementtext-align-lastblitz#998.font-synthesishas a note: Parley's synthetic italic skew is always applied, and the property itself is ignored.I left out
::first-lineand::first-letterbecause they're pseudo-elements, not properties.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/f61e43f395e54276aa990f73969a22c7
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/f61e43f395e54276aa990f73969a22c7?variant=devin-insiders
Requested by: @nicoburns