Order newly tracked CSS properties by popularity within their group - #39
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the entries added in #37 and #38 to their place by popularity within their group (Chrome Status
day_percentage, the max across an entry'sproperties). This matches the page's "roughly ordered by popularity" convention. Existing entries keep their order: each new entry is inserted before the first existing entry that is less popular than it.Examples:
mask-type(3.8%) now comes beforemask-mode(2.1%).scroll-margin(8.5%) now comes beforescroll-padding(6.8%).webkit-text-stroke,paint-orderand the other new Text entries now sit beforetext-decoration-inset(0%).column-fill/column-rule(1.8%) now come beforecolumn-span(0.9%).Data-only change; the moved entries themselves are unchanged.
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/f61e43f395e54276aa990f73969a22c7
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/f61e43f395e54276aa990f73969a22c7?variant=devin-insiders
Requested by: @nicoburns