feat(field): add WithSuggestedValue for GUI-only defaults

[c1-squire-dev]

Problem

WithDefaultValue feeds two independent consumers of a field's default:

1. Runtime/flag default — pkg/cli/cli.go registers it as the cobra flag default, and v.BindPFlags + v.Unmarshal inject it into the connector config even when the stored config omits the field.
2. Schema export — pkg/field/marshal.go emits it as the exported schema default, which the c1 GUI uses to pre-populate the field for a new connector.

Because of (1), adding a default to an existing field is a breaking change: existing connectors whose stored config never set the field suddenly have the default injected at runtime, bypassing any connector-side "unset ⇒ use my own defaults" logic.

Real example: baton-confluence added WithDefaultValue to its noun/verb fields. Existing connectors that relied on the empty-input path (which expands to the connector's full noun/verb set) silently started syncing a narrower set.

Change

Add WithSuggestedValue, a default surfaced only in the exported schema (GUI pre-population). It is not registered as the flag default, so nothing is injected at runtime when the field is unset.

• New SchemaField.SuggestedValue field + WithSuggestedValue(value any) option.
• New GetExportedDefaultValue[T] helper: prefers SuggestedValue, falls back to DefaultValue.
• marshal.go (schema export) now uses GetExportedDefaultValue; cli.go (flag default) is unchanged and still uses DefaultValue.

WithDefaultValue behavior is untouched, so connectors depending on it are unaffected. When both are set, the suggested value wins for schema export while the default value still governs the flag default.

Usage

nounsField = field.StringSliceField(
    "noun",
    field.WithSuggestedValue(defaultNouns), // GUI pre-fill only; no runtime injection
    field.WithRequired(false),
)

Tests

TestSuggestedValue and TestSuggestedValuePrecedence in pkg/field/struct_test.go cover the split (runtime default stays empty; exported schema carries the suggested value; precedence when both set). pkg/field/..., pkg/cli/..., pkg/config/... all pass.

🤖 Generated with Claude Code

[github-actions]

General PR Review: feat(field): add WithSuggestedValue for GUI-only defaults

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base 76f90611805f.
Review mode: full
View review run

Review Summary

The full PR diff was scanned for security and correctness. This adds a WithSuggestedValue field option plus a SuggestedValue struct field and a GetExportedDefaultValue helper, wiring the schema-export path (schemaFieldToV1) to prefer the suggested value while the CLI/runtime flag default (GetDefaultValue, used in pkg/cli/cli.go) is untouched. The change is additive and backward-compatible: SchemaField gains an optional field, all struct literals are keyed so the field reordering is safe, and the runtime default path is unchanged. No security or blocking correctness issues found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

• pkg/field/struct_test.go:143-182: Tests only exercise the StringSliceVariant path. Since GetExportedDefaultValue is generic, a small table covering int/bool/string/map variants would guard the export precedence across all field types.

Prompt for AI agents

Verify each finding against the current code and only fix it if needed.

## Suggestions

In `pkg/field/struct_test.go`:
- Around line 143-182: The suggested-value and precedence tests only cover StringSliceField.
  Add table-driven cases (or additional tests) exercising IntField, BoolField, StringField,
  and StringMapField with WithSuggestedValue (and with both WithDefaultValue + WithSuggestedValue)
  to confirm GetExportedDefaultValue precedence and schemaFieldToV1 export behavior hold for every variant.

[github-actions]

No blocking issues found.