fix(config): use WithSuggestedValue for noun/verb defaults

[c1-squire-dev]

Problem

Commit 6d27d6d added field.WithDefaultValue(defaultNouns) / WithDefaultValue(defaultVerbs) to the noun/verb config fields.

WithDefaultValue feeds two things:

1. the CLI/runtime flag default — pkg/cli registers it as the cobra flag default, and viper (BindPFlags + Unmarshal) injects it into the connector config even when the stored config omits the field;
2. the exported schema default — used by the c1 GUI to pre-populate the field for a new connector.

connector.New → filterArgs treats an empty noun/verb as "use the full default set" (attachment, blogpost, comment, page, space + 8 verbs). Because of (1), an existing connector whose stored config never set noun/verb now gets ["space"] + 6 verbs injected at runtime → filterArgs narrows the sync, dropping nouns {attachment, blogpost, comment, page} and verbs {archive, update}. That's a silent breaking change.

Fix

Use field.WithSuggestedValue (baton-sdk v0.20.1, from ConductorOne/baton-sdk#1024) instead of WithDefaultValue. The suggested value is surfaced only in the exported schema — the GUI still pre-populates noun/verb for new connectors — but it is not registered as the flag default, so nothing is injected at runtime when the field is unset. Existing connectors that leave the fields unset see an empty value at runtime again and keep their historical full-set behavior.

Verification

• ./baton-confluence config (exported schema): noun -> ["space"], verb -> [administer, create, delete, export, read, restrict_content] — GUI pre-population intact.
• Runtime path with no config/env set: Noun=[], Verb=[] — no injection; filterArgs returns the full default set.
• go build ./cmd/baton-confluence and go test ./... pass against baton-sdk v0.20.1.

🤖 Generated with Claude Code

[github-actions]

Connector PR Review: fix(config): use WithSuggestedValue for noun/verb defaults

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base d6b17ea63a1f.
Review mode: full
View review run

Review Summary

The full PR diff was scanned for security and correctness. The substantive change swaps field.WithDefaultValue to field.WithSuggestedValue for the noun/verb config fields, plus the baton-sdk bump (v0.19.1 to tagged v0.20.1) that introduces that option. I verified the fix against the SDK vendor code: the CLI/flag path (cli.go uses GetDefaultValue) reads only DefaultValue, while schema export (marshal.go uses GetExportedDefaultValue) prefers SuggestedValue, so the GUI still pre-populates while nothing is injected at runtime when the field is unset. Since StringSliceField seeds DefaultValue as an empty slice, flag registration stays valid, and filterArgs (connector.go:65) treats the empty runtime value as "use full default set", correctly restoring historical behavior for existing connectors. The prior finding about a baton-sdk branch pseudo-version pin is addressed: go.mod now pins tagged v0.20.1. No new issues found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

[github-actions]

No blocking issues found.

[github-actions]

No blocking issues found.