Skip to content

Validate and repair baseline tests: Item page stats stay stale on range… - #1564

Merged
Ekwav merged 1 commit into
Coflnet:mainfrom
ekwav-agent:ekwav-agent/task_wieln4kshga75m7pftxa
Nov 1, 2026
Merged

Ekwav merged 1 commit into
Coflnet:mainfrom
ekwav-agent:ekwav-agent/task_wieln4kshga75m7pftxa

Conversation

@ekwav-agent

Copy link
Copy Markdown
Contributor

Summary

Behaviour: Tests tolerate calendar month boundaries, listener initialization, and delayed post-visit commands. Production behavior is unchanged.

More detail

Change: Select an available date, await event registration, and translate loading text before releasing the history fixture.

Test:

  • Flip recovery: base cannot find today; repaired suite passes 3/3.
  • Reduced motion: base misses the offline banner; repaired test passes.
  • DOM translation: original times out with a five-second queue delay; repaired version passes that comparison and three consecutive focused runs.
  • TypeScript passes.

Open:

  • Existing tests edited: flip recovery’s date-range retry, reduced motion’s offline banner, and DOM translation’s replaced loading text scenario. Their assertions remain covered.

What is the worst that could happen?

Faulty test synchronization could obscure regressions; reverting restores prior tests without persistent effects.

Validation: 49/49 checks passed · reviewed in a separate claude session · dependencies unchanged.

Checks and provenance
  • node_26
  • npm_ci
  • production_build
  • test_server_ready
  • cypress_account-active-subscription_cy_ts
  • cypress_auction-start_cy_ts
  • cypress_auction_cy_ts
  • cypress_bazaar-plan_cy_ts
  • cypress_bazaar-snapshot-recovery_cy_ts
  • cypress_color-filter_cy_ts
  • cypress_copy-button_cy_ts
  • cypress_crafting-utils_cy_ts
  • cypress_crafts-multi-step_cy_ts
  • cypress_crafts_cy_ts
  • cypress_dom-translation_cy_ts
  • cypress_error-reporting_cy_ts
  • cypress_filter-result-id-utils_cy_ts
  • cypress_filter_cy_ts
  • cypress_flip-tracking-recovery_cy_ts
  • cypress_flipper-recovery_cy_ts
  • cypress_forge_cy_ts
  • cypress_generated-api-client_cy_ts
  • cypress_generated-api-response-utils_cy_ts
  • cypress_goal-utils_cy_ts
  • cypress_google-user-changed_cy_ts
  • cypress_hydration-safe-dates_cy_ts
  • cypress_in-game-command-utils_cy_ts
  • cypress_item-category-check_cy_ts
  • cypress_item-category-utils_cy_ts
  • cypress_item-filter-params-utils_cy_ts
  • cypress_item-redirect-utils_cy_ts
  • cypress_market-analysis_cy_ts
  • cypress_navigation-accessibility_cy_ts
  • cypress_node-toolchain_cy_ts
  • cypress_notification-targets_cy_ts
  • cypress_page-search-utils_cy_ts
  • cypress_player_cy_ts
  • cypress_rat-checker_cy_ts
  • cypress_recent-auctions-recovery_cy_ts
  • cypress_reduced-motion_cy_ts
  • cypress_rsc-cache-poisoning_cy_ts
  • cypress_search-rows-utils_cy_ts
  • cypress_search-shortcut_cy_ts
  • cypress_search_cy_ts
  • cypress_stale-chunk-recovery_cy_ts
  • cypress_startpage-favorites_cy_ts
  • cypress_terms-acceptance_cy_ts
  • cypress_year-view_cy_ts
  • authenticated_year_view_personas

Review notes:

  • Round 1: The flip-tracking test's original .react-datepicker__day--today selector depended on the calendar date and would fail whenever today fell outside the start date's month (during the first seven days of a month), which is a test-only defect and not a production bug.

Task: task_wieln4kshga75m7pftxa

Base: main at f7ab209010377c7de68e4b97ddfc6b475787f7f9

@ekwav-agent
ekwav-agent requested a review from Ekwav November 1, 2026 17:51
@Ekwav
Ekwav merged commit 28b5805 into Coflnet:main Nov 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants