Repository navigation
Refresh item page price statistics when the graph range changes - #1566
Merged
Ekwav merged 2 commits intoNov 1, 2026
Merged
Conversation
Ekwav
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behaviour: Graph statistics refresh across ranges, stale year summaries clear, and leaving a failed year request restores the chart.
More detail
Change: Create fresh chart options, reset range-specific state, and discard outdated responses using per-instance refs.
Test: Cypress regressions fail on base and pass patched:
Open:
/api/item/price/JUDGEMENT_CORE/history/year, backendPricesService.GetDetailedHistorychecked sums.What is the worst that could happen?
Incorrect chart values or loading states; reverting restores prior behaviour without persistent data changes.
Test repair prerequisite
This change builds on the test repair in PR #1564 at commit
28b5805b97a29144cb5182326923710799b52d37. Merge that PR first, then merge this one. This PR targetsmainin the upstream repository; GitHub does not use the prerequisite fork branch as its base.Validation: 50/50 checks passed · reviewed in a separate claude session · dependencies unchanged.
Checks and provenance
node_26npm_ciproduction_buildtest_server_readyregression_base_fail_patch_passcypress_account-active-subscription_cy_tscypress_auction-start_cy_tscypress_auction_cy_tscypress_bazaar-plan_cy_tscypress_bazaar-snapshot-recovery_cy_tscypress_color-filter_cy_tscypress_copy-button_cy_tscypress_crafting-utils_cy_tscypress_crafts-multi-step_cy_tscypress_crafts_cy_tscypress_dom-translation_cy_tscypress_error-reporting_cy_tscypress_filter-result-id-utils_cy_tscypress_filter_cy_tscypress_flip-tracking-recovery_cy_tscypress_flipper-recovery_cy_tscypress_forge_cy_tscypress_generated-api-client_cy_tscypress_generated-api-response-utils_cy_tscypress_goal-utils_cy_tscypress_google-user-changed_cy_tscypress_hydration-safe-dates_cy_tscypress_in-game-command-utils_cy_tscypress_item-category-check_cy_tscypress_item-category-utils_cy_tscypress_item-filter-params-utils_cy_tscypress_item-redirect-utils_cy_tscypress_market-analysis_cy_tscypress_navigation-accessibility_cy_tscypress_node-toolchain_cy_tscypress_notification-targets_cy_tscypress_page-search-utils_cy_tscypress_player_cy_tscypress_rat-checker_cy_tscypress_recent-auctions-recovery_cy_tscypress_reduced-motion_cy_tscypress_rsc-cache-poisoning_cy_tscypress_search-rows-utils_cy_tscypress_search-shortcut_cy_tscypress_search_cy_tscypress_stale-chunk-recovery_cy_tscypress_startpage-favorites_cy_tscypress_terms-acceptance_cy_tscypress_year-view_cy_tsauthenticated_year_view_personasReview notes:
loadPriceHistorybuilds its new options from thechartOptionscaptured when the request started, so a range change from a stale filter callback could briefly lose newer legend state; legend toggles never updated React state on the base commit either.daysstate, default 7) don't follow the chart's range buttons, and the response says so./api/item/price/<tag>/history/year(checked sums inPricesService.GetDetailedHistory), and the frontend has no change for it.{message:'overflow'}, but only the generic server-error text is checked, so the test does not confirm how report B's message would be displayed.Task:
task_sybzwnhiqp2k22qzj2eaBase:
mainat28b5805b97a29144cb5182326923710799b52d37