VV: Compute IPF Colors fully V&V'ed#1666
Merged
imikejackson merged 1 commit intoJul 13, 2026
Merged
Conversation
35 tasks
mmarineBlueQuartz
approved these changes
Jul 13, 2026
Summary: - Confirmed no filter bugs (clean Port); fixed 2 algorithm-review warnings (removed dead GetAllOrientationOps() allocation; phase-warning counter is now std::atomic_int32_t, fixing a data race in the ParallelDataAlgorithm worker); - documented 1 deviation from DREAM3D 6.5.171 (D1 precision+library: +/-1/255 TSL quantization jitter on 14/343963 cells; byte-identical to the stored legacy reference); - retired 1 test (circular oracle that compared filter output against the legacy-produced IPFColors array inside so3_cubic_high_ipf_001.dream3d); - unit tests replaced with inlined Class 1 (Analytical) + Class 4 (Invariant) fixtures plus Class 2 (EbsdLib reference) and Class 3 (standard IPF corner) cross-checks (8 test cases, pass in-core and OOC); - added V&V source-tree deliverables (report + deviations; no provenance sidecar since the oracle dataset is inline with no archive); - renamed GoodVoxels->Mask in the InputValues struct and algorithm internals to match sibling filters, and documented the new Color Key schemes (TSL/PUCM/Nolze-Hielscher) in the user doc. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
imikejackson
force-pushed
the
vv/compute_ipf_colors
branch
from
36f8018 to
a33f67a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full V&V of
ComputeIPFColorsFilter(SIMPLNX UUID64cb4f27-6e5e-4dd2-8a03-0c448cb8f5e6; legacy DREAM3D 6.5.171GenerateIPFColors, SIMPL UUIDa50e6532-8075-5de5-ab63-945feb0de7f7).ComputeIPFColorsis a thin orchestration layer over EbsdLib'sLaueOps::generateIPFColor(). The color math is covered by EbsdLib's own suite (TSLColorKeyTest/PUCMColorKeyTest/NolzeHielscherColorKeyTest/ColorKeyKindTest), so this V&V targets only the SIMPLNX value-add: per-cell dispatch/indexing, masking, reference-direction normalization, phase-bounds handling, and output packing.What changed
IPFColorsarray insideso3_cubic_high_ipf_001.dream3d("our results should match SIMPL/DREAM3D"). Replaced with an inline C++ analytical dataset — no golden file, no archive. (so3_cubic_high_ipf_001.tar.gzstays inCMakeLists.txtbecauseCreateEnsembleInfoTeststill uses it.)GetAllOrientationOps()allocation; made the parallel-written phase-warning counterstd::atomic_int32_t(was a data race in theParallelDataAlgorithmworker).GoodVoxels→Maskin the InputValues struct and algorithm internals to match sibling filters (legacy SIMPL JSON keys kept verbatim for backward-compat).Color Keyschemes (TSL / PUCM / Nolze-Hielscher).Legacy 6.5.171 comparison
Run on
so3_cubic_high_ipf_001(343,963 single-phase cubic cells, TSL, refDir [001]):IPF Colors(0/343,963).Deliverables
vv/ComputeIPFColorsFilter.md(report, Status: READY FOR REVIEW)vv/deviations/ComputeIPFColorsFilter.md(D1)The
vv/comparisons/working set (pipelines + diff) is archived to OneDrive, not committed.🤖 Generated with Claude Code