Skip to content

Fix 3D object scale correctly updated on undo - #9110

Merged
ClementPasteau merged 1 commit into
masterfrom
editor-improvements
Oct 13, 2026
Merged

ClementPasteau merged 1 commit into
masterfrom
editor-improvements

Conversation

@ClementPasteau

Copy link
Copy Markdown
Collaborator

No description provided.

@ClementPasteau ClementPasteau changed the title Allow setting mass override in 2D physics, and add action for 3D Fix 3D object scale correctly updated on undo Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

⏱️ Game engine benchmarks: ✅ no significant change on the 31 benchmarks

All the 31 benchmarks and how they are measured
Benchmark Base This version Change Range between rounds
≈ platformer objects jumping in loop(1000x) 127.3ms 120.7ms -5.2% -16.4% to +5.2%
≈ hitBoxesCollisionTest of 10 objects with 10 objects(10000x) 82.5ms 82.6ms +0.1% -6.7% to +2.2%
≈ hitBoxesCollisionTest of 30 objects with 30 objects(1112x) 26.6ms 26.2ms -1.3% -5.7% to +8.3%
≈ hitBoxesCollisionTest of 100 objects with 100 objects(100x) 8.628ms 9.179ms +6.4% -14.0% to +37.7%
≈ hitBoxesCollisionTest of 500 objects with 500 objects(4x) 1.923ms 2.085ms +8.5% -6.8% to +19.8%
≈ hitBoxesCollisionTest of 1000 objects with 1000 objects(1x) 1.100ms 1.048ms -4.8% -16.9% to +13.6%
≈ hitBoxesCollisionTest of 1 object with 1000 objects(1000x) 53.1ms 52.9ms -0.3% -2.4% to +1.4%
≈ hitBoxesCollisionTest of 10 objects with 1000 objects(100x) 11.3ms 11.1ms -2.5% -5.4% to +5.3%
≈ hitBoxesCollisionTest of 1000 objects with 1 object(1000x) 58.2ms 57.9ms -0.6% -13.6% to +11.5%
≈ hitBoxesCollisionTest of 500 objects with themselves(4x) 1.328ms 1.339ms +0.8% -4.2% to +6.1%
≈ setAngle and setLength(100000x) 11.4ms 11.5ms +0.0% -0.4% to +0.3%
≈ convertCoords(100000x) 21.2ms 21.2ms +0.0% -0.3% to +0.3%
≈ convertInverseCoords(100000x) 21.4ms 21.4ms +0.2% -0.1% to +0.4%
≈ collisionTest between two overlapping rectangles(120000x) 47.4ms 47.2ms -0.3% -14.2% to +1.6%
≈ collisionTest between two non overlapping rectangles(120000x) 11.2ms 11.0ms -1.5% -3.0% to +0.2%
≈ getAABB of a non rotated, default center(180000x) 19.8ms 19.3ms -2.1% -4.2% to +7.9%
≈ getAABB of a rotated, default center(180000x) 20.0ms 19.3ms -3.7% -5.7% to +5.8%
≈ getAABB of a non rotated, non default center(180000x) 20.1ms 20.2ms +0.1% -5.6% to +0.8%
≈ getAABB of a rotated, non default center(180000x) 62.0ms 62.1ms +0.1% -4.1% to +2.2%
≈ getAABB of a non rotated sprite, with custom hitboxes, origin and center(60000x) 19.9ms 19.8ms -0.3% -5.1% to +1.8%
≈ getAABB of a rotated sprite, with custom hitboxes, origin and center(60000x) 67.7ms 67.9ms +0.3% -2.3% to +2.8%
≈ get(400000x) 11.6ms 11.6ms -0.1% -0.2% to +0.1%
≈ Scene: Static sprites (10000) 4.816ms 5.227ms +8.5% -1.7% to +14.7%
≈ Scene: Moving and rotating sprites (5000) 6.759ms 6.626ms -2.0% -8.5% to +14.0%
≈ Scene: Collisions and separation (500 vs 500) 15.7ms 15.3ms -2.6% -6.7% to +4.7%
≈ Scene: Physics 2D (500 bodies) 3.366ms 3.406ms +1.2% -5.4% to +4.0%
≈ Scene: Physics 3D (500 bodies) 13.0ms 13.0ms +0.3% -1.3% to +2.9%
≈ Scene: Platformer characters (300) 1.016ms 1.022ms +0.6% -4.9% to +23.1%
≈ Scene: Text updates (1000) 53.8ms 55.4ms +3.0% -1.4% to +4.7%
≈ Scene: Objects creation and deletion (100 per frame) 1.970ms 2.024ms +2.7% -25.6% to +23.4%
≈ Scene: Heavy events (variables, loops, strings) 1.540ms 1.570ms +1.9% -8.6% to +9.9%

✅ The counters (draw calls, objects count and final state) of the 9 scene benchmarks run on both versions are unchanged.

Comparing 2b38e465 to its base 05629d9b (on a pull request, the version tested is the pull request merged into its base), run alternately 4 times on the same machine (AMD EPYC 7763 64-Core Processor, 4 cores, rendering without GPU). Times are the median duration of a batch of iterations (micro benchmarks) or of a frame (scene benchmarks). A change is reported only when larger than 5% and than the differences between the rounds of a same version, and measured by every pair of rounds.

@ClementPasteau
ClementPasteau merged commit 2f668a1 into master Oct 13, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants