Unbundled binaries - #129
Open
joeyparis wants to merge 9 commits into
Open
Conversation
lusinh
reviewed
Jul 15, 2022
lusinh
reviewed
Jul 15, 2022
lusinh
reviewed
Jul 15, 2022
| RUN pacman -Sy --noconfirm ruby fontconfig freetype2 libjpeg libpng libxext libxrender | ||
|
|
||
| WORKDIR /root/wkhtmltopdf_binary_gem | ||
| COPY . . |
There was a problem hiding this comment.
This repo too heavy to copy all into the image. Why you copy it? We could mount directly repo folder to run
Author
There was a problem hiding this comment.
This PR is specifically to make this repo not heavy
Contributor
|
This would be great. Building a docker image with this gem creates a lot of unnecessary bloat to that base image. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After 0.12.5 the gem size more than quadrupled inside because of a change to how wkhtmltopdf generates their binaries. This pull request removes the bundled binaries and instead downloads the appropriate binary from https://wkhtmltopdf.org/downloads.html based on the operating system and CPU architecture.
This pull request reduces the gem size down to just 6.5K. It also adds support for Amazon Linux 2, which did not appear to be working properly before.
Test Confirmed Supported Platforms
Amazon Linux 2
Arch Linux
CentOS 6
CentOS 7
CentOS 8
Debian 9
Debian 10
Rocky Linux 8
Ubuntu 16
Ubuntu 18
Ubuntu 20
macOS(Can't seem to run on M1 mac)Caveats