Repository navigation
fix(Stepper): correct disabled state when min/max are strings - #6090
Merged
rex-zsd merged 1 commit intoOct 10, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The implementation consistently matches existing click logic and includes focused regression coverage.
0 open findings
What changed in this PR
Aligns Stepper button styling with its numeric min/max click logic when bounds are strings.
Changes:
- Coerces bounds and current values to numbers in disabled-state comparisons.
- Adds a string-bound demo regression case and updates its snapshot.
| File | Description |
|---|---|
packages/stepper/index.wxml |
Fixes numeric disabled-state comparisons. |
packages/stepper/demo/index.wxml |
Adds the regression example. |
packages/stepper/test/__snapshots__/demo.spec.ts.snap |
Verifies correct button styling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
当
min/max以字符串传入时(如min="2" max="10",这也是本组件 demo 的用法),+/-按钮的禁用样式与实际点击逻辑不一致。