let EXTRA_CXXFLAGS override -fsanitize=address in test/Makefile - #2577
Merged
yhirose merged 1 commit intoSep 3, 2026
Merged
Conversation
avionicharshit-byte
marked this pull request as ready for review
September 2, 2026 18:47
Contributor
Author
|
the abi failure here isnt from this pr, its a one line reorder in test/Makefile with no library changes abidiff builds against the last tag, which is v0.54.1, and 7d53a31 (#2575) added a Response param to master's own push run for that commit is red for the same two symbols |
Owner
|
@avionicharshit-byte thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the test suite cannot start on arm64 linux kernels built with a 39 bit virtual address space, raspberry pi os included. asan maps its allocator at a fixed
0x500000000000, the top user address there is0x8000000000, so it aborts before the first test:there is no way to opt out today.
EXTRA_CXXFLAGSsits before-fsanitize=addressinCXXFLAGS, so-fno-sanitize=addressloses. this moves$(EXTRA_CXXFLAGS)to the end. existing ci uses are unaffected,-m32and-fno-exceptionsare position independent and-std=c++17already relies on last wins.verified on a raspberry pi 4, aarch64, gcc 14.2.0.
make CXX=g++ EXTRA_CXXFLAGS=-fno-sanitize=address testbuilds with zero warnings under the existing warning set, and the suite runs:the skips are environmental, 3 want
CPPHTTPLIB_TEST_ISSUE_2431and a sinkhole dns, 1 wants a comma decimal locale that is not installed.this fixes nothing in
httplib.h, arm64 and gcc both look clean.