Fix xt::drop with variables#2912
Open
Alex-PLACET wants to merge 5 commits into
Open
Conversation
…r signed and unsigned char
JohanMabille
requested changes
May 11, 2026
| inline auto drop(T&& indices) | ||
| { | ||
| if constexpr (xtl::is_integral<T>::value) | ||
| if constexpr (xtl::is_integral<std::decay_t<T>>::value) |
Member
There was a problem hiding this comment.
Suggested change
| if constexpr (xtl::is_integral<std::decay_t<T>>::value) | |
| if constexpr (xtl::is_integral<std::remove_cvref_t<T>>::value) |
Member
There was a problem hiding this comment.
I think that we should also start to replace all the xtl::is_integral / is_arithmetic and so on with the standard ones. But let's do that in a dedicated PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Address #2867
Changed
xtl::is_integral<T>::valuetoxtl::is_integral<std::decay_t<T>>::valuein thedrop()function template. When passing a variable likesize_t index = 1,Tdeduces tounsigned long&, a reference type, whichis_integralrejects. Decaying strips the reference so the integral branch is correctly taken.