[renovate]

This PR contains the following updates:

Package	Change	Age	Confidence
filecheck	==1.0.3 → ==1.0.5

---

Release Notes

AntonLydike/filecheck (filecheck)

v1.0.5: v0.1.5: Strict Whitespace follows llvm closely

Compare Source

This patch just changes the --strict-whitespace behaviour to fully align with llvm, mainly to strip whitespace around the match string unless --match-full-lines is also provided.

What's Changed

• Strip whitespace around check strings like upstream by @​AntonLydike in #​53

Full Changelog: AntonLydike/filecheck@v1.0.4...v1.0.5

v1.0.4: : Edgecase Handling

Compare Source

This release brings better handling for edgecases (like running on windows) to filecheck, mainly ones found when integrating with Binaryen. Thanks @​rathann and @​tlively for the support here!

What's Changed

• Skip partially matching lines in --match-full-lines mode (fixes #​47) by @​AntonLydike in #​49
• Add explicit UTF-8 support for files and standard streams by @​tlively in #​51
• Reject whitespace-only checks in non-strict mode by @​tlively in #​50

New Contributors

• @​tlively made their first contribution in #​51

Full Changelog: AntonLydike/filecheck@v1.0.3...v1.0.4

---

Configuration

📅 Schedule: (UTC)

• Branch creation
  • Between 12:00 AM and 03:59 AM, only on Monday (* 0-3 * * 1)
• Automerge
  • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[alexarice]

I think this needs xdslproject/xdsl-template#136, I'll add it now

[alexarice]

I just looked at the error and it actually looks completely different

[alexarice]

See AntonLydike/filecheck#53 . I think we should wait for next release.

[alexarice]

It looks like there will still be some issues, but I'd like to merge #6413 first and see what remains afterwards

[alexarice]

@AntonLydike I had a look at the lower-csl-wrapper.mlir test, which has --match-full-lines but not --strict-whitespace and I can't really tell why filecheck isn't accepting it, but LLVM filecheck does accept it so there's definitely a discrepancy. I'm happy to try to work out what's happening but and send a patch but thought I'd check if you had an idea first. I haven't looked through the other failing tests yet.

[superlopuh]

Yep it does seem like a bug @AntonLydike, it seems like it's not stripping leading spaces.

[AntonLydike]

Interesting, I will take a look!

[AntonLydike]

I am considering adding xdsl tests to the filecheck CI, how long are the xdsl tests taking normally now?

[alexarice]

The ci takes a few minutes

[alexarice]

The problem is that some of the errors here were/are actual errors in the test, that the newer version (correctly) checks more strictly than before

[AntonLydike]

I just tried to run the patch from AntonLydike/filecheck#54 against xdsl, and there are still two tests failing:

tests/filecheck/dialects/builtin/invalid_attrs.mlir and tests/filecheck/dialects/complex/invalid_attr.mlir are both strict+full matching, but have // CHECK: <pattern> (with a space between CHECK: and <pattern>), meaning the expected pattern on the line is <pattern> (leading space) which fails to match the line, which is just <pattern>. I guess those two actually need updating in this PR. This change in filecheck is not a bug.

[alexarice]

I'm doing the same and agree these tests are broken. There's also a filecheck failure in the toy tests, and I haven't checked if this is an xdsl fault yet

[alexarice]

Pushed a fix to the tests that were broken. I've also temporarily pointed at the main branch of filecheck for testing.

[renovate]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.95%. Comparing base (420a5cb) to head (718508e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6411   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files         439      439           
  Lines       65980    65983    +3     
  Branches     7511     7511           
=======================================
+ Hits        57371    57374    +3     
  Misses       7038     7038           
  Partials     1571     1571           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[AntonLydike]

Release of v0.1.6 minted!

[superlopuh]

Nice! Thank you @alexarice @AntonLydike